Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescrip...
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 6 Nov 2018 15:46:13 +0000 (15:46 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 6 Nov 2018 15:46:13 +0000 (15:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191278

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Updating test according upstreamed WPT.
Rebased test accordingly.

* web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt:
* web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html:

LayoutTests:

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html

index ce267d2..492c981 100644 (file)
@@ -1,3 +1,12 @@
+2018-11-06  Youenn Fablet  <youenn@apple.com>
+
+        Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=191278
+
+        Reviewed by Eric Carlson.
+
+        * TestExpectations:
+
 2018-11-06  Thibault Saunier  <tsaunier@igalia.com>
 
         [GStreamer][WebRTC] Implement black frame generation
index 7c7c61c..8dc9070 100644 (file)
@@ -2905,5 +2905,3 @@ fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-element
 # FIXME: The behavior of navigator.mediaDevices.enumerateDevices is in flux, skip these tests for now.
 http/tests/media/media-stream/enumerate-devices-source-id-persistent.html [ Skip ]
 http/tests/media/media-stream/enumerate-devices-source-id.html [ Skip ]
-
-webkit.org/b/237773 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html [ Pass Failure ]
index 3a53791..22dd072 100644 (file)
@@ -1,3 +1,16 @@
+2018-11-06  Youenn Fablet  <youenn@apple.com>
+
+        Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=191278
+
+        Reviewed by Eric Carlson.
+
+        Updating test according upstreamed WPT.
+        Rebased test accordingly.
+
+        * web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt:
+        * web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html:
+
 2018-11-06  Ali Juma  <ajuma@chromium.org>
 
         [IntersectionObserver] Account for CSS zoom when computing client rects
index 08fce5f..7f15bab 100644 (file)
@@ -4,7 +4,7 @@ Harness Error (TIMEOUT), message = null
 PASS addTrack() with a track and no stream makes ontrack fire with a track and no stream. 
 PASS addTrack() with a track and a stream makes ontrack fire with a track and a stream. 
 PASS ontrack fires before setRemoteDescription resolves. 
-FAIL addTrack() with two tracks and one stream makes ontrack fire twice with the tracks and shared stream. assert_array_equals: The remote stream == [first track, second track]. property 0, expected object "[object MediaStreamTrack]" but got object "[object MediaStreamTrack]"
+PASS addTrack() with two tracks and one stream makes ontrack fire twice with the tracks and shared stream. 
 PASS addTrack() for an existing stream makes stream.onaddtrack fire. 
 PASS stream.onaddtrack fires before setRemoteDescription resolves. 
 PASS addTrack() with a track and two streams makes ontrack fire with a track and two streams. 
index 7179f1e..c9d2d12 100644 (file)
                   'Second ontrack\'s stream ID matches local stream.');
     assert_array_equals(firstTrackEvent.streams, secondTrackEvent.streams,
                         'ontrack was fired with the same streams both times.');
-    assert_array_equals(firstTrackEvent.streams[0].getTracks(),
-                        [firstTrackEvent.track, secondTrackEvent.track],
-                        'The remote stream == [first track, second track].');
+
+    assert_equals(firstTrackEvent.streams[0].getTracks().length, 2, "stream should have two tracks");
+    assert_true(firstTrackEvent.streams[0].getTracks().includes(firstTrackEvent.track), "remoteStream should have the first track");
+    assert_true(firstTrackEvent.streams[0].getTracks().includes(secondTrackEvent.track), "remoteStream should have the second track");
+    assert_equals(ontrackEventsFired, 2, 'Unexpected number of track events.');
+
     assert_equals(ontrackEventsFired, 2, 'Unexpected number of track events.');
   }, 'addTrack() with two tracks and one stream makes ontrack fire twice with the tracks and shared stream.');