Remove failing assertion introduced in r234873
authorachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 15 Aug 2018 17:48:07 +0000 (17:48 +0000)
committerachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 15 Aug 2018 17:48:07 +0000 (17:48 +0000)
https://bugs.webkit.org/show_bug.cgi?id=188581

* contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
The assertion is correct but failing because VectorTraits<String> is incorrect.
I'll re-add it and fix VectorTraits<String> in a separate patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/contentextensions/ContentExtensionCompiler.cpp

index c052c63..14f4e23 100644 (file)
@@ -1,3 +1,13 @@
+2018-08-15  Alex Christensen  <achristensen@webkit.org>
+
+        Remove failing assertion introduced in r234873
+        https://bugs.webkit.org/show_bug.cgi?id=188581
+
+        * contentextensions/ContentExtensionCompiler.cpp:
+        (WebCore::ContentExtensions::compileRuleList):
+        The assertion is correct but failing because VectorTraits<String> is incorrect.
+        I'll re-add it and fix VectorTraits<String> in a separate patch.
+
 2018-08-15  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         [Attachment SPI] Remove attachment display mode options
index 35a72dc..9cabadb 100644 (file)
@@ -285,12 +285,6 @@ static void compileToBytecode(CombinedURLFilters&& filters, UniversalActionSet&&
 
 std::error_code compileRuleList(ContentExtensionCompilationClient& client, String&& ruleJSON, Vector<ContentExtensionRule>&& parsedRuleList)
 {
-#if !ASSERT_DISABLED
-    callOnMainThread([ruleJSON = ruleJSON.isolatedCopy(), parsedRuleList = parsedRuleList.isolatedCopy()] {
-        ASSERT(parseRuleList(ruleJSON) == parsedRuleList);
-    });
-#endif
-
     bool domainConditionSeen = false;
     bool topURLConditionSeen = false;
     for (const auto& rule : parsedRuleList) {