Simplify platform check in WebEditorClient
authordon.olmstead@sony.com <don.olmstead@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 20 Nov 2018 03:04:35 +0000 (03:04 +0000)
committerdon.olmstead@sony.com <don.olmstead@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 20 Nov 2018 03:04:35 +0000 (03:04 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191848

Reviewed by Fujii Hironori.

!PLATFORM(GTK) && !PLATFORM(COCOA) && !PLATFORM(WPE) can be better
represented as PLATFORM(WIN).

* WebProcess/WebCoreSupport/WebEditorClient.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp

index 1103c2e..7aa7384 100644 (file)
@@ -1,3 +1,15 @@
+2018-11-19  Don Olmstead  <don.olmstead@sony.com>
+
+        Simplify platform check in WebEditorClient
+        https://bugs.webkit.org/show_bug.cgi?id=191848
+
+        Reviewed by Fujii Hironori.
+
+        !PLATFORM(GTK) && !PLATFORM(COCOA) && !PLATFORM(WPE) can be better
+        represented as PLATFORM(WIN).
+
+        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
+
 2018-11-19  Alex Christensen  <achristensen@webkit.org>
 
         Add SPI to disable JIT in a WKWebView
index acde2f0..ab3367a 100644 (file)
@@ -359,7 +359,7 @@ void WebEditorClient::redo()
     m_page->sendSync(Messages::WebPageProxy::ExecuteUndoRedo(UndoOrRedo::Redo), Messages::WebPageProxy::ExecuteUndoRedo::Reply());
 }
 
-#if !PLATFORM(GTK) && !PLATFORM(COCOA) && !PLATFORM(WPE)
+#if PLATFORM(WIN)
 void WebEditorClient::handleKeyboardEvent(KeyboardEvent* event)
 {
     if (m_page->handleEditingKeyboardEvent(event))
@@ -370,7 +370,7 @@ void WebEditorClient::handleInputMethodKeydown(KeyboardEvent*)
 {
     notImplemented();
 }
-#endif
+#endif // PLATFORM(WIN)
 
 void WebEditorClient::textFieldDidBeginEditing(Element* element)
 {