PatchLog process durations are increasing linearly with time (faulty data logging)
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 1 Feb 2013 15:27:15 +0000 (15:27 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 1 Feb 2013 15:27:15 +0000 (15:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=108621

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-01
Reviewed by Eric Seidel.

Added a check to prevent a stop event from happening to the same patch multiple times.

* QueueStatusServer/loggers/recordpatchevent.py:
(RecordPatchEvent.stopped):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/QueueStatusServer/app.yaml
Tools/QueueStatusServer/loggers/recordpatchevent.py

index 5460f6f..0e67d7c 100644 (file)
@@ -1,3 +1,15 @@
+2013-02-01  Alan Cutter  <alancutter@chromium.org>
+
+        PatchLog process durations are increasing linearly with time (faulty data logging)
+        https://bugs.webkit.org/show_bug.cgi?id=108621
+
+        Reviewed by Eric Seidel.
+
+        Added a check to prevent a stop event from happening to the same patch multiple times.
+
+        * QueueStatusServer/loggers/recordpatchevent.py:
+        (RecordPatchEvent.stopped):
+
 2013-02-01  Manuel Rego Casasnovas  <rego@igalia.com>
 
         [GTK][WK2] MiniBrowser fullscreen signals support
index ea3f7ea..050c82c 100644 (file)
@@ -1,5 +1,5 @@
 application: webkit-commit-queue
-version: 108427 # Bugzilla bug ID of last major change
+version: 108621 # Bugzilla bug ID of last major change
 runtime: python
 api_version: 1
 
index 4cddb60..08c57cd 100644 (file)
@@ -85,15 +85,16 @@ class RecordPatchEvent(object):
             WarningLog.record("patchlog wait duration missing", "In stopped event.", attachment_id, queue_name, bot_id)
             return
 
-        if bot_id:
-            patch_log.bot_id = bot_id
-        patch_log.finished = True
-        patch_log.calculate_process_duration()
-        patch_log.put()
+        if not patch_log.finished:
+            if bot_id:
+                patch_log.bot_id = bot_id
+            patch_log.finished = True
+            patch_log.calculate_process_duration()
+            patch_log.put()
 
-        queue_log = QueueLog.get_current(queue_name, queue_log_duration)
-        queue_log.patch_process_durations.append(patch_log.process_duration)
-        queue_log.put()
+            queue_log = QueueLog.get_current(queue_name, queue_log_duration)
+            queue_log.patch_process_durations.append(patch_log.process_duration)
+            queue_log.put()
 
     @classmethod
     def updated(cls, attachment_id, queue_name, bot_id=None):