Adjust inlining threshold for new bytecode format
authortzagallo@apple.com <tzagallo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 31 Oct 2018 18:44:11 +0000 (18:44 +0000)
committertzagallo@apple.com <tzagallo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 31 Oct 2018 18:44:11 +0000 (18:44 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191115

Reviewed by Saam Barati.

The new format reduced the number of operands for many opcodes, which
changed inlining decisions and impacted performance negatively.

* runtime/Options.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/runtime/Options.h

index 52ab4be..b87fe99 100644 (file)
@@ -1,5 +1,17 @@
 2018-10-31  Tadeu Zagallo  <tzagallo@apple.com>
 
+        Adjust inlining threshold for new bytecode format
+        https://bugs.webkit.org/show_bug.cgi?id=191115
+
+        Reviewed by Saam Barati.
+
+        The new format reduced the number of operands for many opcodes, which
+        changed inlining decisions and impacted performance negatively.
+
+        * runtime/Options.h:
+
+2018-10-31  Tadeu Zagallo  <tzagallo@apple.com>
+
         REGRESSION(r237547): Exception handlers should be aware of wide opcodes
         https://bugs.webkit.org/show_bug.cgi?id=191108
         <rdar://problem/45690700>
index 046bc92..3223a92 100644 (file)
@@ -303,7 +303,7 @@ constexpr bool enableWebAssemblyStreamingApi = false;
     \
     v(unsigned, maximumOptimizationCandidateInstructionCount, 100000, Normal, nullptr) \
     \
-    v(unsigned, maximumFunctionForCallInlineCandidateInstructionCount, 190, Normal, nullptr) \
+    v(unsigned, maximumFunctionForCallInlineCandidateInstructionCount, 120, Normal, nullptr) \
     v(unsigned, maximumFunctionForClosureCallInlineCandidateInstructionCount, 100, Normal, nullptr) \
     v(unsigned, maximumFunctionForConstructInlineCandidateInstructionCount, 100, Normal, nullptr) \
     \