Web Inspector: Network Table appears broken after filter - rows look collapsed
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Jan 2019 21:23:31 +0000 (21:23 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Jan 2019 21:23:31 +0000 (21:23 +0000)
https://bugs.webkit.org/show_bug.cgi?id=192730
<rdar://problem/46853158>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2019-01-22
Reviewed by Devin Rousso.

* UserInterface/Views/Table.js:
(WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
Affect the filler row like the other applyColumnWidths calls since this
now may be the initial call to size visible columns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/Table.js

index a272ef1..67cdda3 100644 (file)
@@ -1,3 +1,16 @@
+2019-01-22  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Network Table appears broken after filter - rows look collapsed
+        https://bugs.webkit.org/show_bug.cgi?id=192730
+        <rdar://problem/46853158>
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/Table.js:
+        (WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
+        Affect the filler row like the other applyColumnWidths calls since this
+        now may be the initial call to size visible columns.
+
 2019-01-22  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: Audit: use plural strings for Passed, Failed, and Unsupported
index 2bc6f34..3520247 100644 (file)
@@ -1153,11 +1153,13 @@ WI.Table = class Table extends WI.View
     {
         // Apply and create missing cells only if row needs a width update.
         for (let row of this._listElement.children) {
-            if (row.__widthGeneration !== this._widthGeneration && row !== this._fillerRow) {
+            if (row.__widthGeneration !== this._widthGeneration) {
                 for (let i = 0; i < row.children.length; ++i)
                     row.children[i].style.width = this._columnWidths[i] + "px";
-                if (row.children.length !== this._visibleColumns.length)
-                    this._populateRow(row);
+                if (row !== this._fillerRow) {
+                    if (row.children.length !== this._visibleColumns.length)
+                        this._populateRow(row);
+                }
                 row.__widthGeneration = this._widthGeneration;
             }
         }