2010-10-05 Adam Barth <abarth@webkit.org>
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Oct 2010 03:04:18 +0000 (03:04 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Oct 2010 03:04:18 +0000 (03:04 +0000)
        Reviewed by Darin Adler.

        Issue in treebuilder parsing related to table tags
        https://bugs.webkit.org/show_bug.cgi?id=47190

        Add test coverage.

        * html5lib/resources/webkit02.dat:
2010-10-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Issue in treebuilder parsing related to table tags
        https://bugs.webkit.org/show_bug.cgi?id=47190

        Update ASSERT to match the spec and our behavior.

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processEndTagForInCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@69170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/html5lib/resources/webkit02.dat
WebCore/ChangeLog
WebCore/html/parser/HTMLTreeBuilder.cpp

index 619a086..15aa797 100644 (file)
@@ -1,3 +1,14 @@
+2010-10-05  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Issue in treebuilder parsing related to table tags
+        https://bugs.webkit.org/show_bug.cgi?id=47190
+
+        Add test coverage.
+
+        * html5lib/resources/webkit02.dat:
+
 2010-10-05  Kenneth Russell  <kbr@google.com>
 
         Unreviewed, test expectations update.
index 69fbe5d..468879b 100644 (file)
 | <html>
 |   <head>
 |   <body>
+
+#data
+<table><td></tbody>A
+#errors
+#document
+| <html>
+|   <head>
+|   <body>
+|     "A"
+|     <table>
+|       <tbody>
+|         <tr>
+|           <td>
+
+#data
+<table><td></thead>A
+#errors
+#document
+| <html>
+|   <head>
+|   <body>
+|     <table>
+|       <tbody>
+|         <tr>
+|           <td>
+|             "A"
+
+#data
+<table><td></tfoot>A
+#errors
+#document
+| <html>
+|   <head>
+|   <body>
+|     <table>
+|       <tbody>
+|         <tr>
+|           <td>
+|             "A"
+
+#data
+<table><thead><td></tbody>A
+#errors
+#document
+| <html>
+|   <head>
+|   <body>
+|     <table>
+|       <thead>
+|         <tr>
+|           <td>
+|             "A"
index ca04b87..7967095 100644 (file)
@@ -1,3 +1,15 @@
+2010-10-05  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Issue in treebuilder parsing related to table tags
+        https://bugs.webkit.org/show_bug.cgi?id=47190
+
+        Update ASSERT to match the spec and our behavior.
+
+        * html/parser/HTMLTreeBuilder.cpp:
+        (WebCore::HTMLTreeBuilder::processEndTagForInCell):
+
 2010-10-05  Victoria Kirst  <vrk@google.com>
 
         Reviewed by James Robinson.
index 355dc8d..a2236d5 100644 (file)
@@ -1849,7 +1849,7 @@ void HTMLTreeBuilder::processEndTagForInCell(AtomicHTMLToken& token)
         || token.name() == trTag
         || isTableBodyContextTag(token.name())) {
         if (!m_tree.openElements()->inTableScope(token.name())) {
-            ASSERT(isParsingFragment());
+            ASSERT(isTableBodyContextTag(token.name()) || isParsingFragment());
             parseError(token);
             return;
         }