2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
authorpodivilov@chromium.org <podivilov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 27 Jan 2011 14:14:49 +0000 (14:14 +0000)
committerpodivilov@chromium.org <podivilov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 27 Jan 2011 14:14:49 +0000 (14:14 +0000)
        Unreviewed, rolling out r76789.
        http://trac.webkit.org/changeset/76789
        https://bugs.webkit.org/show_bug.cgi?id=53238

        Broke GTK layout tests (Requested by podivilov on #webkit).

        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane):
        (WebInspector.ScopeChainSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/ScopeChainSidebarPane.js

index 1d20174..f6ced11 100644 (file)
@@ -1,3 +1,15 @@
+2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r76789.
+        http://trac.webkit.org/changeset/76789
+        https://bugs.webkit.org/show_bug.cgi?id=53238
+
+        Broke GTK layout tests (Requested by podivilov on #webkit).
+
+        * inspector/front-end/ScopeChainSidebarPane.js:
+        (WebInspector.ScopeChainSidebarPane):
+        (WebInspector.ScopeChainSidebarPane.prototype.update):
+
 2011-01-27  Yury Semikhatsky  <yurys@chromium.org>
 
         Reviewed by Pavel Feldman.
index bdbb0cf..d3190a9 100644 (file)
@@ -26,8 +26,6 @@
 WebInspector.ScopeChainSidebarPane = function()
 {
     WebInspector.SidebarPane.call(this, WebInspector.UIString("Scope Variables"));
-    this._sections = [];
-    this._expandedSections = {};
     this._expandedProperties = [];
 }
 
@@ -36,6 +34,9 @@ WebInspector.ScopeChainSidebarPane.prototype = {
     {
         this.bodyElement.removeChildren();
 
+        this.sections = [];
+        this.callFrame = callFrame;
+
         if (!callFrame) {
             var infoElement = document.createElement("div");
             infoElement.className = "info";
@@ -44,18 +45,6 @@ WebInspector.ScopeChainSidebarPane.prototype = {
             return;
         }
 
-        for (var i = 0; i < this._sections.length; ++i) {
-            var section = this._sections[i];
-            if (!section.title)
-                continue;
-            if (section.expanded)
-                this._expandedSections[section.title] = true;
-            else
-                delete this._expandedSections[section.title];
-        }
-
-        this._sections = [];
-
         var foundLocalScope = false;
         var scopeChain = callFrame.scopeChain;
         for (var i = 0; i < scopeChain.length; ++i) {
@@ -92,10 +81,10 @@ WebInspector.ScopeChainSidebarPane.prototype = {
             section.editInSelectedCallFrameWhenPaused = true;
             section.pane = this;
 
-            if (!foundLocalScope || scopeObjectProxy.isLocal || title in this._expandedSections)
+            if (!foundLocalScope || scopeObjectProxy.isLocal)
                 section.expanded = true;
 
-            this._sections.push(section);
+            this.sections.push(section);
             this.bodyElement.appendChild(section.element);
         }
     }