Partially revert r257135 now that the underlying bug is resolved
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 30 Jun 2020 22:01:35 +0000 (22:01 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 30 Jun 2020 22:01:35 +0000 (22:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=213814
<rdar://problem/59859573>

Reviewed by Per Arne Vollan.

This patch is a partial revert of the code change in Bug 208033, where a temporary
workaround was added for a bug in an underlying framework. Now that the bug has been
fixed, we can remove this workaround.

* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::gpuProcessSessionParameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp

index 8bc463e..c9786e0 100644 (file)
@@ -1,5 +1,20 @@
 2020-06-30  Brent Fulgham  <bfulgham@apple.com>
 
+        Partially revert r257135 now that the underlying bug is resolved
+        https://bugs.webkit.org/show_bug.cgi?id=213814
+        <rdar://problem/59859573>
+
+        Reviewed by Per Arne Vollan.
+
+        This patch is a partial revert of the code change in Bug 208033, where a temporary
+        workaround was added for a bug in an underlying framework. Now that the bug has been
+        fixed, we can remove this workaround.
+
+        * UIProcess/GPU/GPUProcessProxy.cpp:
+        (WebKit::gpuProcessSessionParameters):
+
+2020-06-30  Brent Fulgham  <bfulgham@apple.com>
+
         [macOS] Stop blocking two audio-related user client classes
         https://bugs.webkit.org/show_bug.cgi?id=213807
         <rdar://problem/64874902>
index 2f845aa..15fe60a 100644 (file)
@@ -280,13 +280,8 @@ static inline GPUProcessSessionParameters gpuProcessSessionParameters(const Webs
 
     parameters.mediaCacheDirectory = store.resolvedMediaCacheDirectory();
     SandboxExtension::Handle mediaCacheDirectoryExtensionHandle;
-    if (!parameters.mediaCacheDirectory.isEmpty()) {
-        String parentFolder = parameters.mediaCacheDirectory;
-        auto position = parentFolder.reverseFind("/");
-        if (position != notFound)
-            parentFolder = parentFolder.substring(0, position);
-        SandboxExtension::createHandleWithoutResolvingPath(parentFolder, SandboxExtension::Type::ReadWrite, parameters.mediaCacheDirectorySandboxExtensionHandle);
-    }
+    if (!parameters.mediaCacheDirectory.isEmpty())
+        SandboxExtension::createHandleWithoutResolvingPath(parameters.mediaCacheDirectory, SandboxExtension::Type::ReadWrite, parameters.mediaCacheDirectorySandboxExtensionHandle);
 
 #if ENABLE(LEGACY_ENCRYPTED_MEDIA)
     parameters.mediaKeysStorageDirectory = store.resolvedMediaKeysDirectory();