Reviewed by Maciej.
authorap <ap@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 1 Mar 2007 17:08:24 +0000 (17:08 +0000)
committerap <ap@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 1 Mar 2007 17:08:24 +0000 (17:08 +0000)
        http://bugs.webkit.org/show_bug.cgi?id=12801
        Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document

        Test: editing/pasteboard/createMarkup-assert.xml

        * editing/markup.cpp:
        (WebCore::createMarkup): Removed the assertion, because it's wrong in a non-HTML world.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/editing/pasteboard/createMarkup-assert-expected.txt [new file with mode: 0644]
LayoutTests/editing/pasteboard/createMarkup-assert.xml [new file with mode: 0644]
WebCore/ChangeLog
WebCore/editing/markup.cpp

index a9d33b1..2118e93 100644 (file)
@@ -1,3 +1,13 @@
+2007-03-01  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Maciej.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=12801
+          Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document
+
+        * editing/pasteboard/createMarkup-assert-expected.txt: Added.
+        * editing/pasteboard/createMarkup-assert.xml: Added.
+
 2007-02-28  Geoffrey Garen  <ggaren@apple.com>
 
         Reviewed by Bradeee Eidson.
diff --git a/LayoutTests/editing/pasteboard/createMarkup-assert-expected.txt b/LayoutTests/editing/pasteboard/createMarkup-assert-expected.txt
new file mode 100644 (file)
index 0000000..3b39002
--- /dev/null
@@ -0,0 +1 @@
+Test for <http://bugs.webkit.org/show_bug.cgi?id=12801> Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document.
diff --git a/LayoutTests/editing/pasteboard/createMarkup-assert.xml b/LayoutTests/editing/pasteboard/createMarkup-assert.xml
new file mode 100644 (file)
index 0000000..5d062f7
--- /dev/null
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<root>
+<text>Test for &lt;http://bugs.webkit.org/show_bug.cgi?id=12801> Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document.</text>
+<script xmlns="http://www.w3.org/1999/xhtml" type="text/javascript">
+    if (window.layoutTestController)
+        layoutTestController.dumpAsText();
+
+    document.execCommand("selectall");
+    document.execCommand("copy");
+</script>
+</root>
index c3995d4..f24c2a5 100644 (file)
@@ -1,3 +1,15 @@
+2007-03-01  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Maciej.
+
+        http://bugs.webkit.org/show_bug.cgi?id=12801
+        Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document
+
+        Test: editing/pasteboard/createMarkup-assert.xml
+
+        * editing/markup.cpp:
+        (WebCore::createMarkup): Removed the assertion, because it's wrong in a non-HTML world.
+
 2007-02-28  Adam Roben  <aroben@apple.com>
 
         Reviewed by Oliver and Hyatt.
index da2ae76..7baad54 100644 (file)
@@ -394,7 +394,6 @@ DeprecatedString createMarkup(const Range *range, Vector<Node*>* nodes, EAnnotat
         root = range->startPosition().node();
         while (root && !root->hasTagName(bodyTag))
             root = root->parentNode();
-        ASSERT(root);
         if (!root)
             root = doc->documentElement();
     }