Unreviewed, silence a -Wreturn-type warning
authormcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 25 Oct 2018 19:55:12 +0000 (19:55 +0000)
committermcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 25 Oct 2018 19:55:12 +0000 (19:55 +0000)
When every return is supposed to be covered by a switch statement, a release assert or CRASH
is required by GCC.

* Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:
(WebCore::LibWebRTCCertificateGenerator::keyParamsFromCertificateType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp

index 94e0d5d..096a3da 100644 (file)
@@ -1,3 +1,13 @@
+2018-10-25  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed, silence a -Wreturn-type warning
+
+        When every return is supposed to be covered by a switch statement, a release assert or CRASH
+        is required by GCC.
+
+        * Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:
+        (WebCore::LibWebRTCCertificateGenerator::keyParamsFromCertificateType):
+
 2018-10-25  Antoine Quint  <graouts@apple.com>
 
         [Web Animations] Turn Web Animations CSS Integration off by default
index 1f1ebf2..3a705e6 100644 (file)
@@ -98,6 +98,8 @@ static inline rtc::KeyParams keyParamsFromCertificateType(const PeerConnectionBa
             return rtc::KeyParams::RSA(info.rsaParameters->modulusLength, info.rsaParameters->publicExponent);
         return rtc::KeyParams::RSA(2048, 65537);
     }
+
+    RELEASE_ASSERT_NOT_REACHED();
 }
 
 void generateCertificate(LibWebRTCProvider& provider, const PeerConnectionBackend::CertificateInformation& info, DOMPromiseDeferred<IDLInterface<RTCCertificate>>&& promise)