Web Inspector: Command-/ (slash) now auto-comments code via CodeMirror 4. Should...
authorjonowells@apple.com <jonowells@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 26 Jun 2014 22:15:43 +0000 (22:15 +0000)
committerjonowells@apple.com <jonowells@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 26 Jun 2014 22:15:43 +0000 (22:15 +0000)
https://bugs.webkit.org/show_bug.cgi?id=134313

Reviewed by Timothy Hatcher.

Changed alternate command to pause/resume from command-slash to command-backslash.
Command-slash sets/unsets comments in all code editors.

* UserInterface/Models/KeyboardShortcut.js: Added Backslash.
* UserInterface/Views/DebuggerSidebarPanel.js: Changed pauseOrResumeAlternateKeyboardShortcut to use Backslash instead of Slash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@170497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Models/KeyboardShortcut.js
Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js

index 501286d..776980f 100644 (file)
@@ -1,3 +1,16 @@
+2014-06-26  Jono Wells  <jonowells@apple.com>
+
+        Web Inspector: Command-/ (slash) now auto-comments code via CodeMirror 4. Should remove as command to pause
+        https://bugs.webkit.org/show_bug.cgi?id=134313
+
+        Reviewed by Timothy Hatcher.
+
+        Changed alternate command to pause/resume from command-slash to command-backslash.
+        Command-slash sets/unsets comments in all code editors.
+
+        * UserInterface/Models/KeyboardShortcut.js: Added Backslash.
+        * UserInterface/Views/DebuggerSidebarPanel.js: Changed pauseOrResumeAlternateKeyboardShortcut to use Backslash instead of Slash.
+
 2014-06-25  Jono Wells  <jonowells@apple.com>
 
         Web Inspector: Rules panel's strikethrough gets confused at -webkit-align-items: flex-start;
index ef68c24..896ad46 100644 (file)
@@ -154,6 +154,7 @@ WebInspector.KeyboardShortcut.Key = {
     Minus: new WebInspector.Key(189, "-"),
     Period: new WebInspector.Key(190, "."),
     Slash: new WebInspector.Key(191, "/"),
+    Backslash: new WebInspector.Key(220, "\\"),
     Apostrophe: new WebInspector.Key(192, "`"),
     SingleQuote: new WebInspector.Key(222, "\'")
 };
index ebc460a..27d6356 100644 (file)
@@ -45,7 +45,7 @@ WebInspector.DebuggerSidebarPanel = function()
     this._stepIntoKeyboardShortcut = new WebInspector.KeyboardShortcut(null, WebInspector.KeyboardShortcut.Key.F7, this._debuggerStepIntoButtonClicked.bind(this));
     this._stepOutKeyboardShortcut = new WebInspector.KeyboardShortcut(null, WebInspector.KeyboardShortcut.Key.F8, this._debuggerStepOutButtonClicked.bind(this));
 
-    this.pauseOrResumeAlternateKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, WebInspector.KeyboardShortcut.Key.Slash, this._debuggerPauseResumeButtonClicked.bind(this));
+    this.pauseOrResumeAlternateKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, WebInspector.KeyboardShortcut.Key.Backslash, this._debuggerPauseResumeButtonClicked.bind(this));
     this._stepOverAlternateKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, WebInspector.KeyboardShortcut.Key.SingleQuote, this._debuggerStepOverButtonClicked.bind(this));
     this._stepIntoAlternateKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.CommandOrControl, WebInspector.KeyboardShortcut.Key.Semicolon, this._debuggerStepIntoButtonClicked.bind(this));
     this._stepOutAlternateKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Shift | WebInspector.KeyboardShortcut.Modifier.CommandOrControl, WebInspector.KeyboardShortcut.Key.Semicolon, this._debuggerStepOutButtonClicked.bind(this));