Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non...
authorryanhaddad@apple.com <ryanhaddad@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Jun 2019 21:35:13 +0000 (21:35 +0000)
committerryanhaddad@apple.com <ryanhaddad@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Jun 2019 21:35:13 +0000 (21:35 +0000)
https://bugs.webkit.org/show_bug.cgi?id=198616
rdar://problem/36386573

Patch by Alexey Proskuryakov <ap@apple.com> on 2019-06-10
Reviewed by David Kilzer.

Adding an explicit STRIP_STYLE to appropriate xcconfigs.

* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
* DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
* DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
* ImageDiff/cg/Configurations/ImageDiff.xcconfig:
* MiniBrowser/Configurations/MiniBrowser.xcconfig:
* MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
* TestWebKitAPI/Configurations/TestWTF.xcconfig:
* TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
* WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
* WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig
Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig
Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig
Tools/ImageDiff/cg/Configurations/ImageDiff.xcconfig
Tools/MiniBrowser/Configurations/MiniBrowser.xcconfig
Tools/MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig
Tools/TestWebKitAPI/Configurations/TestWTF.xcconfig
Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig
Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig
Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig

index cce5ef6..60addab 100644 (file)
@@ -1,3 +1,24 @@
+2019-06-10  Alexey Proskuryakov  <ap@apple.com>
+
+        Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
+        https://bugs.webkit.org/show_bug.cgi?id=198616
+        rdar://problem/36386573
+
+        Reviewed by David Kilzer.
+
+        Adding an explicit STRIP_STYLE to appropriate xcconfigs.
+
+        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
+        * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
+        * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
+        * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
+        * MiniBrowser/Configurations/MiniBrowser.xcconfig:
+        * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
+        * TestWebKitAPI/Configurations/TestWTF.xcconfig:
+        * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
+        * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
+        * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
+
 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
index a4eb04c..711f77c 100644 (file)
@@ -27,6 +27,7 @@ OTHER_LDFLAGS = $(inherited) $(PLATFORM_OTHER_LDFLAGS) $(ASAN_OTHER_LDFLAGS);
 PLATFORM_OTHER_LDFLAGS[sdk=iphone*] = -framework JavaScriptCore;
 PLATFORM_OTHER_LDFLAGS[sdk=macosx*] = -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework Carbon -framework Cocoa -framework JavaScriptCore -framework OpenGL -framework QuartzCore -framework WebKit;
 LD_RUNPATH_SEARCH_PATHS = "@loader_path/.";
+STRIP_STYLE = debugging;
 PRODUCT_NAME = DumpRenderTree;
 SKIP_INSTALL[sdk=macosx*] = NO;
 SKIP_INSTALL[sdk=iphone*] = YES;
index ed2bf73..c762059 100644 (file)
@@ -31,6 +31,8 @@ OTHER_LDFLAGS = $(PLATFORM_OTHER_LDFLAGS) $(ASAN_OTHER_LDFLAGS);
 PLATFORM_OTHER_LDFLAGS[sdk=iphone*] = -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework QuartzCore -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework Foundation -framework GraphicsServices -framework ImageIO -framework MobileCoreServices -framework UIKit -framework WebCore -framework JavaScriptCore -framework WebKit $(OTHER_LDFLAGS_FONTS);
 PLATFORM_OTHER_LDFLAGS[sdk=macosx*] = -framework JavaScriptCore;
 
+STRIP_STYLE = debugging;
+
 LD_RUNPATH_SEARCH_PATHS = "@loader_path/.";
 
 EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] = ios/*;
index f69c565..de644cc 100644 (file)
@@ -26,3 +26,4 @@
 #include "BaseTarget.xcconfig"
 
 OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -framework Carbon -framework Cocoa -framework OpenGL -framework IOKit;
+STRIP_STYLE = debugging;
index 55c5fc4..558e5e5 100644 (file)
@@ -28,3 +28,4 @@ GCC_ENABLE_OBJC_EXCEPTIONS = YES;
 PRODUCT_NAME = ImageDiff;
 OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -framework Carbon -framework Cocoa -framework QuartzCore;
 OTHER_LDFLAGS[sdk=iphone*] = $(inherited) -framework CoreFoundation -framework CoreGraphics -framework MobileCoreServices -framework ImageIO;
+STRIP_STYLE = debugging;
index 4cf45dd..03de7bc 100644 (file)
@@ -28,3 +28,4 @@ GCC_PREFIX_HEADER = mac/MiniBrowser_Prefix.pch
 INFOPLIST_FILE = mac/Info.plist
 EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = *
 OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -framework Cocoa -framework WebKit
+STRIP_STYLE = debugging;
index f329577..920aae5 100644 (file)
@@ -22,3 +22,5 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 PRODUCT_NAME = MiniBrowser
+
+STRIP_STYLE=debugging
index c2a8489..f6372e7 100644 (file)
@@ -36,3 +36,5 @@ OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = -framework Cocoa -framework Carbon;
 
 // FIXME: This should not be built on iOS. Instead we should create and use a TestWTF application.
 OTHER_LDFLAGS_PLATFORM[sdk=iphone*] = -framework CoreGraphics;
+
+STRIP_STYLE = debugging;
index 0207440..c6dfb33 100644 (file)
@@ -37,3 +37,5 @@ OTHER_LDFLAGS_PLATFORM[sdk=iphone*] = -framework WebCore -framework CoreGraphics
 LD_RUNPATH_SEARCH_PATHS = "@loader_path";
 
 CODE_SIGN_ENTITLEMENTS[sdk=iphone*] = Configurations/TestWebKitAPI-iOS.entitlements;
+
+STRIP_STYLE = debugging;
index dfcdfd9..4e51923 100644 (file)
@@ -30,6 +30,7 @@ LD_RUNPATH_SEARCH_PATHS = "@loader_path";
 PRODUCT_NAME = WebKitTestRunner;
 GCC_ENABLE_OBJC_EXCEPTIONS = YES;
 OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -lWebKitTestRunner -framework Carbon -framework Cocoa -framework JavaScriptCore -framework WebKit;
+STRIP_STYLE = debugging;
 SKIP_INSTALL[sdk=iphone*] = YES;
 EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = mac/*;
 INCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = mac/main.mm;
index 607a8bd..afcd2eb 100644 (file)
@@ -32,6 +32,8 @@ GCC_ENABLE_OBJC_EXCEPTIONS = YES;
 
 OTHER_LDFLAGS = $(inherited) -lWebKitTestRunner -lWebCoreTestSupport -framework JavaScriptCore -framework CoreGraphics -framework QuartzCore -framework ImageIO -framework IOKit -framework UIKit -framework WebKit -framework Foundation -framework GraphicsServices;
 
+STRIP_STYLE = debugging;
+
 SKIP_INSTALL[sdk=macosx*] = YES;
 
 EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] = ios/* AppDelegate.m;