https://bugs.webkit.org/show_bug.cgi?id=168684
Patch by Caio Lima <ticaiolima@gmail.com> on 2017-03-13
Reviewed by Saam Barati.
JSTests:
* ChakraCore/test/LetConst/DeclOutofBlock.baseline-jsc:
Source/JavaScriptCore:
This patch is fixing a Parser bug to allow define a label named
```let``` in sloppy mode when parsing a Statement.
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseStatement):
LayoutTests:
* js/let-syntax-expected.txt:
* js/script-tests/let-syntax.js:
(shouldNotHaveSyntaxErrorSloopyOnly):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
-SyntaxError: Unexpected identifier 'b'. Parse error.
+SyntaxError: Unexpected identifier 'b'
SyntaxError: Unexpected keyword 'const'
-SyntaxError: Unexpected identifier 'd'. Parse error.
-SyntaxError: Unexpected identifier 'd'. Parse error.
-SyntaxError: Unexpected identifier 'f'. Parse error.
+SyntaxError: Unexpected identifier 'd'
+SyntaxError: Unexpected identifier 'd'
+SyntaxError: Unexpected identifier 'f'
success
+2017-03-13 Caio Lima <ticaiolima@gmail.com>
+
+ [JSC] It should be possible create a label named let when parsing Statement in non strict mode
+ https://bugs.webkit.org/show_bug.cgi?id=168684
+
+ Reviewed by Saam Barati.
+
+ * ChakraCore/test/LetConst/DeclOutofBlock.baseline-jsc:
+
2017-03-10 Saam Barati <sbarati@apple.com>
WebAssembly: Make more demos run
+2017-03-13 Caio Lima <ticaiolima@gmail.com>
+
+ [JSC] It should be possible create a label named let when parsing Statement in non strict mode
+ https://bugs.webkit.org/show_bug.cgi?id=168684
+
+ Reviewed by Saam Barati.
+
+ * js/let-syntax-expected.txt:
+ * js/script-tests/let-syntax.js:
+ (shouldNotHaveSyntaxErrorSloopyOnly):
+
2017-03-13 Ryan Haddad <ryanhaddad@apple.com>
Rebaseline js/dom/global-constructors-attributes.html.
PASS Does not have syntax error: ''use strict'; let x = { get foo() { let foo = 20; } };'
PASS Does not have syntax error: 'let x = { get foo() { class foo { } } };'
PASS Does not have syntax error: ''use strict'; let x = { get foo() { class foo { } } };'
+PASS Does not have syntax error: 'let x; with ({}) let: y = 3;'
SyntaxError: Unexpected keyword 'let'. Can't use 'let' as an identifier name for a LexicalDeclaration.
SyntaxError: Unexpected keyword 'let'. Can't use 'let' as an identifier name for a LexicalDeclaration.
PASS Has syntax error: 'let let;'
SyntaxError: Cannot declare a let variable twice: 'i'.
SyntaxError: Cannot declare a let variable twice: 'i'.
PASS Has syntax error: ''use strict'; for (let i = 20, j = 40, i = 10; i < 10; i++) {}'
-SyntaxError: Unexpected identifier 'x'. Parse error.
-SyntaxError: Unexpected identifier 'x'. Parse error.
+SyntaxError: Unexpected identifier 'x'
+SyntaxError: Unexpected identifier 'x'
PASS Has syntax error: 'let x = 20; if (truth()) let x = 40;'
SyntaxError: Unexpected keyword 'let'
SyntaxError: Unexpected keyword 'let'
SyntaxError: Cannot declare a class twice: 'x'.
SyntaxError: Cannot declare a class twice: 'x'.
PASS Has syntax error: ''use strict'; function f() { function x(){}; class x{}; }'
+SyntaxError: Unexpected identifier 'y'
+SyntaxError: Unexpected identifier 'y'
+PASS Has syntax error: 'let x; with ({}) let y = 3;'
ReferenceError: Can't find variable: let
PASS Does not have syntax error: 'let;'
SyntaxError: Unexpected token ';'. Expected a parameter pattern or a ')' in parameter list.
SyntaxError: Cannot use the keyword 'let' as a catch parameter name.
SyntaxError: Cannot use the keyword 'let' as a catch parameter name.
PASS Has syntax error: ''use strict'; try { } catch(let) {}'
+PASS Does not have syntax error: 'let x; if (true) let: x = 3;'
+SyntaxError: Unexpected keyword 'let'
+SyntaxError: Unexpected keyword 'let'
+PASS Has syntax error: ''use strict'; let x; if (true) let: x = 3;'
PASS successfullyParsed is true
TEST COMPLETE
testPassed("Has syntax error: '" + str + "'");
}
+function shouldHaveSyntaxErrorSloppyOnly(str) {
+ assert(hasSyntaxError(str));
+ assert(hasSyntaxError("function dummy() { " + str + " }"));
+ testPassed("Has syntax error: '" + str + "'");
+}
function shouldNotHaveSyntaxError(str) {
assert(!hasSyntaxError(str));
testPassed("Has syntax error: '" + str + "'");
}
+function shouldNotHaveSyntaxErrorSloppyOnly(str)
+{
+ assert(!hasSyntaxError(str));
+ assert(!hasSyntaxError("(function dummy() { " + str + " })"));
+ testPassed("Does not have syntax error: '" + str + "'");
+}
+
shouldNotHaveSyntaxError("let x = 20; if (truth()) { let x = 30; }");
shouldNotHaveSyntaxError("let {x} = {x:20}; if (truth()) { let {x} = {x : 20}; }");
shouldNotHaveSyntaxError("let {x} = {x:20}; if (truth()) { let {y: x} = {y : 20}; }");
shouldNotHaveSyntaxError("let x = { get foo() { const foo = 20; } };");
shouldNotHaveSyntaxError("let x = { get foo() { let foo = 20; } };");
shouldNotHaveSyntaxError("let x = { get foo() { class foo { } } };");
+shouldNotHaveSyntaxErrorSloppyOnly("let x; with ({}) let: y = 3;");
shouldHaveSyntaxError("let let;");
shouldHaveSyntaxError("const let;");
shouldHaveSyntaxError("function f() { class x{}; var [x] = 20; }");
shouldHaveSyntaxError("function f() { class x{}; function x(){} }");
shouldHaveSyntaxError("function f() { function x(){}; class x{}; }");
+shouldHaveSyntaxErrorSloppyOnly("let x; with ({}) let y = 3;");
// Stay classy, ES6.
shouldHaveSyntaxErrorStrictOnly("let;");
shouldHaveSyntaxErrorStrictOnly("let: for (v in {}) break;");
shouldHaveSyntaxErrorStrictOnly("let: for (var v = 0; false; ) {};");
shouldHaveSyntaxErrorStrictOnly("try { } catch(let) {}");
+shouldHaveSyntaxErrorStrictOnly("let x; if (true) let: x = 3;");
+2017-03-13 Caio Lima <ticaiolima@gmail.com>
+
+ [JSC] It should be possible create a label named let when parsing Statement in non strict mode
+ https://bugs.webkit.org/show_bug.cgi?id=168684
+
+ Reviewed by Saam Barati.
+
+ This patch is fixing a Parser bug to allow define a label named
+ ```let``` in sloppy mode when parsing a Statement.
+
+ * parser/Parser.cpp:
+ (JSC::Parser<LexerType>::parseStatement):
+
2017-03-11 Filip Pizlo <fpizlo@apple.com>
Structure::willStoreValueSlow needs to keep the property table alive until the end
case DEFAULT:
// These tokens imply the end of a set of source elements
return 0;
+ case LET: {
+ if (!strictMode())
+ goto identcase;
+ goto defaultCase;
+ }
case ASYNC:
if (maybeParseAsyncFunctionDeclarationStatement(context, result, parentAllowsFunctionDeclarationAsStatement))
break;
case IDENT:
case AWAIT:
case YIELD: {
+ identcase:
bool allowFunctionDeclarationAsStatement = false;
result = parseExpressionOrLabelStatement(context, allowFunctionDeclarationAsStatement);
shouldSetPauseLocation = !context.shouldSkipPauseLocation(result);
nonTrivialExpressionCount = m_parserState.nonTrivialExpressionCount;
FALLTHROUGH;
default:
+ defaultCase:
TreeStatement exprStatement = parseExpressionStatement(context);
if (directive && nonTrivialExpressionCount != m_parserState.nonTrivialExpressionCount)
directive = nullptr;