Web Inspector: system accent color follow-ups
authormattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 7 Mar 2019 00:13:15 +0000 (00:13 +0000)
committermattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 7 Mar 2019 00:13:15 +0000 (00:13 +0000)
https://bugs.webkit.org/show_bug.cgi?id=195190

Reviewed by Devin Rousso.

* UserInterface/Views/ButtonToolbarItem.css:
(.toolbar .item.button:not(.disabled):matches(:focus, .activate.activated)):
(@media (prefers-color-scheme: dark)):
(.toolbar .item.button:not(.disabled):active:matches(:focus, .activate.activated)): Deleted.
Drop pressed toolbar button style. It's extremely subtle and not worth the hassle.

* UserInterface/Views/LogContentView.css:
(.console-messages:focus .console-item.selected::after):
(@media (prefers-color-scheme: dark)):

* UserInterface/Views/ScopeBar.css:
(.scope-bar > li.selected:active::before):

* UserInterface/Views/TimelineRecordBar.css:
(.timeline-record-bar.selected > .segment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css
Source/WebInspectorUI/UserInterface/Views/LogContentView.css
Source/WebInspectorUI/UserInterface/Views/ScopeBar.css
Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.css

index 98a7316..68f6ee8 100644 (file)
@@ -1,5 +1,28 @@
 2019-03-06  Matt Baker  <mattbaker@apple.com>
 
+        Web Inspector: system accent color follow-ups
+        https://bugs.webkit.org/show_bug.cgi?id=195190
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/ButtonToolbarItem.css:
+        (.toolbar .item.button:not(.disabled):matches(:focus, .activate.activated)):
+        (@media (prefers-color-scheme: dark)):
+        (.toolbar .item.button:not(.disabled):active:matches(:focus, .activate.activated)): Deleted.
+        Drop pressed toolbar button style. It's extremely subtle and not worth the hassle.
+
+        * UserInterface/Views/LogContentView.css:
+        (.console-messages:focus .console-item.selected::after):
+        (@media (prefers-color-scheme: dark)):
+
+        * UserInterface/Views/ScopeBar.css:
+        (.scope-bar > li.selected:active::before):
+
+        * UserInterface/Views/TimelineRecordBar.css:
+        (.timeline-record-bar.selected > .segment):
+
+2019-03-06  Matt Baker  <mattbaker@apple.com>
+
         REGRESSION: Elements tab: Uncaught Exception: No node with given id found
         https://bugs.webkit.org/show_bug.cgi?id=194299
         <rdar://problem/47828647>
index 7037563..cd1c6d6 100644 (file)
 }
 
 .toolbar .item.button:not(.disabled):matches(:focus, .activate.activated) {
-    color: var(--selected-background-color);
-}
-
-.toolbar .item.button:not(.disabled):active:matches(:focus, .activate.activated) {
-    color: var(--selected-background-color-active);
+    color: var(--glyph-color-active);
 }
 
 .toolbar .item.button > .glyph {
@@ -73,11 +69,7 @@ body.window-inactive .toolbar .item.button.disabled {
         background: var(--button-background-color-pressed);
     }
 
-    .toolbar .item.button:not(.disabled):matches(:focus, .activate.activated) {
-        color: var(--glyph-color-active);
-    }
-
-    .toolbar .item.button:not(.disabled):active:matches(:focus, .activate.activated) {
-        color: var(--glyph-color-active-pressed);
+    body:not(.window-inactive) .toolbar .item.button:not(.disabled):matches(:focus, .activate.activated) > .glyph {
+        filter: brightness(1.35);
     }
 }
index ad96a3d..f3ef50a 100644 (file)
@@ -148,7 +148,7 @@ body[dir=rtl] .log-scope-bar > li.unread::before {
 }
 
 .console-messages:focus .console-item.selected::after {
-    background: hsl(210, 100%, 49%);
+    background-color: var(--glyph-color-active);
 }
 
 .console-messages:focus .console-item.selected .go-to-link {
@@ -309,10 +309,6 @@ body[dir=rtl] .console-group-title::before {
         color: var(--selected-secondary-text-color-active);
     }
 
-    .console-messages:focus .console-item.selected::after {
-        background: hsl(210, 100%, 75%);
-    }
-
     .console-error-level {
         background-color: var(--error-background-color-secondary);
         border-color: var(--border-color-error);
index ecef8eb..2eff6a9 100644 (file)
@@ -69,7 +69,7 @@
 }
 
 .scope-bar > li.selected:active::before {
-    filter: brightness(0.6);
+    filter: brightness(0.8);
 }
 
 .scope-bar > li.multiple {
index 5e5d2dd..0b30dae 100644 (file)
@@ -42,8 +42,8 @@
 }
 
 .timeline-record-bar.selected > .segment {
-    background-color: var(--selected-background-color) !important;
-    border-color: var(--selected-background-color-active) !important;
+    background-color: var(--selected-text-background-color) !important;
+    border-color: var(--glyph-color-active) !important;
 }
 
 .timeline-record-bar:not(.has-inactive-segment) > .segment {