Reviewed by Nikolas & Oliver.
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Jan 2008 06:48:57 +0000 (06:48 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Jan 2008 06:48:57 +0000 (06:48 +0000)
        Tested by svg/custom/svg-features.html

        * dom/DOMImplementation.cpp:
        (WebCore::isSVG10Feature): use ENABLE(SVG_*) conditionals
        (WebCore::isSVG11Feature): use ENABLE(SVG_*) conditionals

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/svg/custom/svg-features-expected.txt
WebCore/ChangeLog
WebCore/dom/DOMImplementation.cpp

index 0eca7d1..64bd4bf 100644 (file)
@@ -1,3 +1,9 @@
+2008-01-21  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Nikolas & Oliver.
+        
+        * svg/custom/svg-features-expected.txt: updated to reflect foreignObject off and fonts on
+
 2008-01-21  Geoffrey Garen  <ggaren@apple.com>
 
         Layout test for http://bugs.webkit.org/show_bug.cgi?id=16909
index 46f4391..db8f918 100644 (file)
@@ -52,6 +52,6 @@
 "http://www.w3.org/TR/SVG11/feature#View", "1.1": false, false
 "http://www.w3.org/TR/SVG11/feature#Script", "1.1": true, true
 "http://www.w3.org/TR/SVG11/feature#Animation", "1.1": false, false
-"http://www.w3.org/TR/SVG11/feature#Font", "1.1": false, false
-"http://www.w3.org/TR/SVG11/feature#BasicFont", "1.1": false, false
-"http://www.w3.org/TR/SVG11/feature#Extensibility", "1.1": true, true
+"http://www.w3.org/TR/SVG11/feature#Font", "1.1": true, true
+"http://www.w3.org/TR/SVG11/feature#BasicFont", "1.1": true, true
+"http://www.w3.org/TR/SVG11/feature#Extensibility", "1.1": false, false
index f5da0d7..da8135f 100644 (file)
@@ -1,3 +1,13 @@
+2008-01-21  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Nikolas & Oliver.
+        
+        Tested by svg/custom/svg-features.html
+        
+        * dom/DOMImplementation.cpp:
+        (WebCore::isSVG10Feature): use ENABLE(SVG_*) conditionals
+        (WebCore::isSVG11Feature): use ENABLE(SVG_*) conditionals
+
 2008-01-21  Geoffrey Garen  <ggaren@apple.com>
 
         Reviewed by Maciej Stachowiak.
index fb36288..c6904ec 100644 (file)
@@ -74,18 +74,19 @@ static bool isSVG10Feature(const String &feature)
     static bool initialized = false;
     static HashSet<String, CaseFoldingHash> svgFeatures;
     if (!initialized) {
-        // Sadly, we cannot claim to implement any SVG 1.0 feature set, due to
-        // lack of Font support.
-        // http://bugs.webkit.org/show_bug.cgi?id=15480
-//      addString(svgFeatures, "svg");
-//      addString(svgFeatures, "svg.static");
+#if ENABLE(SVG_USE) && ENABLE(SVG_FOREIGN_OBJECT) && ENABLE(SVG_FILTER) && ENABLE(SVG_FONTS)
+        addString(svgFeatures, "svg");
+        addString(svgFeatures, "svg.static");
+#endif
 //      addString(svgFeatures, "svg.animation");
 //      addString(svgFeatures, "svg.dynamic");
 //      addString(svgFeatures, "svg.dom.animation");
 //      addString(svgFeatures, "svg.dom.dynamic");
-//      addString(svgFeatures, "dom");
-//      addString(svgFeatures, "dom.svg");
-//      addString(svgFeatures, "dom.svg.static");
+#if ENABLE(SVG_USE) && ENABLE(SVG_FOREIGN_OBJECT) && ENABLE(SVG_FILTER) && ENABLE(SVG_FONTS)
+        addString(svgFeatures, "dom");
+        addString(svgFeatures, "dom.svg");
+        addString(svgFeatures, "dom.svg.static");
+#endif
 //      addString(svgFeatures, "svg.all");
 //      addString(svgFeatures, "dom.svg.all");
         initialized = true;
@@ -101,10 +102,12 @@ static bool isSVG11Feature(const String &feature)
         // Sadly, we cannot claim to implement any of the SVG 1.1 generic feature sets
         // lack of Font and Filter support.
         // http://bugs.webkit.org/show_bug.cgi?id=15480
-//      addString(svgFeatures, "SVG");
-//      addString(svgFeatures, "SVGDOM");
-//      addString(svgFeatures, "SVG-static");
-//      addString(svgFeatures, "SVGDOM-static");
+#if ENABLE(SVG_USE) && ENABLE(SVG_FOREIGN_OBJECT) && ENABLE(SVG_FILTER) && ENABLE(SVG_FONTS)
+        addString(svgFeatures, "SVG");
+        addString(svgFeatures, "SVGDOM");
+        addString(svgFeatures, "SVG-static");
+        addString(svgFeatures, "SVGDOM-static");
+#endif
 //      addString(svgFeatures, "SVG-animation);
 //      addString(svgFeatures, "SVGDOM-animation);
 //      addString(svgFeatures, "SVG-dynamic);
@@ -128,7 +131,7 @@ static bool isSVG11Feature(const String &feature)
         addString(svgFeatures, "GraphicsAttribute");
         addString(svgFeatures, "BaseGraphicsAttribute");
         addString(svgFeatures, "Marker");
-//      addString(svgFeatures, "ColorProfile");
+//      addString(svgFeatures, "ColorProfile"); // requires color-profile, bug 6037
         addString(svgFeatures, "Gradient");
         addString(svgFeatures, "Pattern");
         addString(svgFeatures, "Clip");
@@ -145,12 +148,16 @@ static bool isSVG11Feature(const String &feature)
         addString(svgFeatures, "Hyperlinking");
         addString(svgFeatures, "XlinkAttribute");
         addString(svgFeatures, "ExternalResourcesRequired");
-//      addString(svgFeatures, "View");
+//      addString(svgFeatures, "View"); // buggy <view> support, bug 16962
         addString(svgFeatures, "Script");
-//      addString(svgFeatures, "Animation");
-//      addString(svgFeatures, "Font");
-//      addString(svgFeatures, "BasicFont");
+//      addString(svgFeatures, "Animation"); // <animate> support missing
+#if ENABLE(SVG_FONTS)
+        addString(svgFeatures, "Font");
+        addString(svgFeatures, "BasicFont");
+#endif
+#if ENABLE(SVG_FOREIGN_OBJECT)
         addString(svgFeatures, "Extensibility");
+#endif
         initialized = true;
     }
     return svgFeatures.contains(feature);