REGRESSION (r233552): Find highlight has white text on yellow background
authortimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Jul 2018 23:19:27 +0000 (23:19 +0000)
committertimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Jul 2018 23:19:27 +0000 (23:19 +0000)
https://bugs.webkit.org/show_bug.cgi?id=187535
rdar://problem/42043371

Reviewed by Tim Horton.

Fixes existing image tests:
- fast/text/mark-matches-rendering.html
- fast/text/mark-matches-broken-line-rendering.html

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::resolveStyleForMarkedText): Remove incorect UseDarkAppearance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/rendering/InlineTextBox.cpp

index 3ccd52f..492ba57 100644 (file)
@@ -1,3 +1,18 @@
+2018-07-10  Timothy Hatcher  <timothy@apple.com>
+
+        REGRESSION (r233552): Find highlight has white text on yellow background
+        https://bugs.webkit.org/show_bug.cgi?id=187535
+        rdar://problem/42043371
+
+        Reviewed by Tim Horton.
+
+        Fixes existing image tests:
+        - fast/text/mark-matches-rendering.html
+        - fast/text/mark-matches-broken-line-rendering.html
+
+        * rendering/InlineTextBox.cpp:
+        (WebCore::InlineTextBox::resolveStyleForMarkedText): Remove incorect UseDarkAppearance.
+
 2018-07-10  Chris Fleizach  <cfleizach@apple.com>
 
         AX: Crash in accessing AXObjectCache in textMarkerDataForVisiblePosition
index 034afbc..f725053 100644 (file)
@@ -767,7 +767,7 @@ auto InlineTextBox::resolveStyleForMarkedText(const MarkedText& markedText, cons
     }
     case MarkedText::TextMatch: {
         // Text matches always use the light system appearance.
-        OptionSet<StyleColor::Options> styleColorOptions = { StyleColor::Options::UseSystemAppearance, StyleColor::Options::UseDarkAppearance };
+        OptionSet<StyleColor::Options> styleColorOptions = { StyleColor::Options::UseSystemAppearance };
 #if PLATFORM(MAC)
         style.textStyles.fillColor = renderer().theme().systemColor(CSSValueAppleSystemLabel, styleColorOptions);
 #endif