Make attaching and detaching the Web Inspector instantaneous.
authortimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 12 Aug 2008 17:45:39 +0000 (17:45 +0000)
committertimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 12 Aug 2008 17:45:39 +0000 (17:45 +0000)
        This also preserves the current view, other state, and keeps
        the script debugger attached.

        https://bugs.webkit.org/show_bug.cgi?id=19301

        Reviewed by Adam Roben.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController close]): Only call setWindowVisible(false)
        when not moving windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/mac/ChangeLog
WebKit/mac/WebCoreSupport/WebInspectorClient.mm

index a57ade0..c513a9e 100644 (file)
@@ -1,3 +1,17 @@
+2008-08-12  Timothy Hatcher  <timothy@apple.com>
+
+        Make attaching and detaching the Web Inspector instantaneous.
+        This also preserves the current view, other state, and keeps
+        the script debugger attached.
+
+        https://bugs.webkit.org/show_bug.cgi?id=19301
+
+        Reviewed by Adam Roben.
+
+        * WebCoreSupport/WebInspectorClient.mm:
+        (-[WebInspectorWindowController close]): Only call setWindowVisible(false)
+        when not moving windows.
+
 2008-08-12  Dan Bernstein  <mitz@apple.com>
 
         Reviewed by John Sullivan.
index 3ef5367..edd2c3e 100644 (file)
@@ -266,7 +266,8 @@ void WebInspectorClient::updateWindowTitle() const
 
     _visible = NO;
 
-    [_inspectedWebView page]->inspectorController()->setWindowVisible(false);
+    if (!_movingWindows)
+        [_inspectedWebView page]->inspectorController()->setWindowVisible(false);
 
     [self hideHighlight];