[Qt][WK2] Fail to activate links after double tap gesture.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 9 Apr 2012 19:31:39 +0000 (19:31 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 9 Apr 2012 19:31:39 +0000 (19:31 +0000)
https://bugs.webkit.org/show_bug.cgi?id=83468

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-09
Reviewed by Kenneth Rohde Christiansen.

.:

* ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.

Source/WebKit2:

After a recognized double tap gesture, QtTapGestureRecognizer
gets stuck in the double-tap state. Only tapping outside of
the double tap radius cancels it.
Call reset() to set the default state back.

* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::recognize):

ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
ManualTests/link-activation-fails-after-double-tap-gesture.html [new file with mode: 0644]
Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp

index 185c572..12467fa 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2012-04-09  Zalan Bujtas  <zbujtas@gmail.com>
+
+        [Qt][WK2] Fail to activate links after double tap gesture.
+        https://bugs.webkit.org/show_bug.cgi?id=83468
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        * ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.
+
 2012-04-09  Martin Robinson  <mrobinson@igalia.com>
 
         [soup] Crash while loading http://www.jusco.cn
diff --git a/ManualTests/link-activation-fails-after-double-tap-gesture.html b/ManualTests/link-activation-fails-after-double-tap-gesture.html
new file mode 100644 (file)
index 0000000..84cdd8d
--- /dev/null
@@ -0,0 +1,7 @@
+<html>
+<body>
+    <p>This test verifies that after the double tap gesture, links can still be activated.</p>
+    <p>Double tap <span style='color: red'>here</span> and <a href="data:text/html,<html><body style='background-color:green'>PASS</body></html>">try to activate this link</a> with single tap.</p>
+    <p>PASS if new page loads.</p>
+</body>
+</html>
index b74a330..d547c4d 100644 (file)
@@ -1,3 +1,20 @@
+2012-04-09  Zalan Bujtas  <zbujtas@gmail.com>
+
+        [Qt][WK2] Fail to activate links after double tap gesture.
+        https://bugs.webkit.org/show_bug.cgi?id=83468
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        After a recognized double tap gesture, QtTapGestureRecognizer
+        gets stuck in the double-tap state. Only tapping outside of
+        the double tap radius cancels it.
+        Call reset() to set the default state back.
+
+        * UIProcess/qt/QtTapGestureRecognizer.cpp:
+        (WebKit::QtTapGestureRecognizer::recognize):
+
+        ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.
+
 2012-04-07  Patrick Gansterer  <paroga@webkit.org>
 
         [CMake] Cleanup WTF include directories
index 00a34e3..6509b2f 100644 (file)
@@ -86,6 +86,7 @@ bool QtTapGestureRecognizer::recognize(const QTouchEvent* event, qint64 eventTim
         if (m_candidate == DoubleTapCandidate) {
             m_eventHandler->handlePotentialSingleTapEvent(QTouchEvent::TouchPoint());
             m_eventHandler->handleDoubleTapEvent(touchPoint);
+            reset();
         }
 
         break;