[LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
authorzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 29 Jan 2019 15:53:30 +0000 (15:53 +0000)
committerzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 29 Jan 2019 15:53:30 +0000 (15:53 +0000)
https://bugs.webkit.org/show_bug.cgi?id=193964

Reviewed by Antti Koivisto.

Source/WebCore:

* layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginBefore):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp
Tools/ChangeLog
Tools/LayoutReloaded/misc/LFC-passing-tests.txt

index e6b3538..0c1fd2c 100644 (file)
@@ -1,5 +1,15 @@
 2019-01-29  Zalan Bujtas  <zalan@apple.com>
 
+        [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
+        https://bugs.webkit.org/show_bug.cgi?id=193964
+
+        Reviewed by Antti Koivisto.
+
+        * layout/blockformatting/BlockMarginCollapse.cpp:
+        (WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginBefore):
+
+2019-01-29  Zalan Bujtas  <zalan@apple.com>
+
         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
         https://bugs.webkit.org/show_bug.cgi?id=193954
 
index 958ed35..179defb 100644 (file)
@@ -155,7 +155,7 @@ void BlockFormattingContext::placeInFlowPositionedChildren(const Box& layoutBox)
         if (!childBox.isInFlowPositioned())
             continue;
 
-        auto computeInFlowPositionedPosition = [&]() {
+        auto computeInFlowPositionedPosition = [&] {
             auto& layoutState = this->layoutState();
             auto positionOffset = Geometry::inFlowPositionedPositionOffset(layoutState, childBox);
 
index 4d50145..f7b1c02 100644 (file)
@@ -538,7 +538,7 @@ PositiveAndNegativeVerticalMargin::Values BlockFormattingContext::MarginCollapse
     auto previouSiblingCollapsedMarginAfter = [&]() -> PositiveAndNegativeVerticalMargin::Values {
         if (!marginBeforeCollapsesWithPreviousSiblingMarginAfter(layoutState, layoutBox))
             return { };
-        return positiveNegativeValues(layoutState, *downcast<Container>(layoutBox).previousInFlowSibling(), MarginType::After);
+        return positiveNegativeValues(layoutState, *layoutBox.previousInFlowSibling(), MarginType::After);
     };
 
     // 1. Gather positive and negative margin values from first child if margins are adjoining.
index 0d0461d..e261411 100644 (file)
@@ -1,5 +1,14 @@
 2019-01-29  Zalan Bujtas  <zalan@apple.com>
 
+        [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
+        https://bugs.webkit.org/show_bug.cgi?id=193964
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/misc/LFC-passing-tests.txt:
+
+2019-01-29  Zalan Bujtas  <zalan@apple.com>
+
         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
         https://bugs.webkit.org/show_bug.cgi?id=193954
 
index af555da..eda150d 100644 (file)
@@ -149,6 +149,7 @@ fast/block/margin-collapse/043.html
 fast/block/margin-collapse/044.html
 fast/block/margin-collapse/063.html
 fast/block/margin-collapse/100.html
+fast/block/margin-collapse/101.html
 fast/block/margin-collapse/collapsed-through-child-simple.html
 fast/block/positioning/003.html
 fast/block/positioning/004.html