[ews-build] Do not run clean build by default on EWS builders
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 15 Apr 2019 20:12:39 +0000 (20:12 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 15 Apr 2019 20:12:39 +0000 (20:12 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196897

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/steps.py:
(ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing
untracked directories like WebKitBuild).
(CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
untracked files/directories (like WebKitBuild).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/ews-build/steps.py
Tools/ChangeLog

index 760a90b..19bf3d8 100644 (file)
@@ -93,6 +93,7 @@ class CheckOutSource(git.Git):
                                                 retry=self.CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR,
                                                 timeout=2 * 60 * 60,
                                                 alwaysUseLatest=True,
+                                                method='clean',
                                                 progress=True,
                                                 **kwargs)
 
@@ -133,7 +134,6 @@ class ApplyPatch(shell.ShellCommand, CompositeStepMixin):
             return None
 
         d = self.downloadFileContentToWorker('.buildbot-diff', patch)
-        d.addCallback(lambda _: self.downloadFileContentToWorker('.buildbot-patched', 'patched\n'))
         d.addCallback(lambda res: shell.ShellCommand.start(self))
 
     def getResultSummary(self):
index 35f7526..f269b8b 100644 (file)
@@ -1,3 +1,17 @@
+2019-04-15  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Do not run clean build by default on EWS builders
+        https://bugs.webkit.org/show_bug.cgi?id=196897
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
+        file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
+        untracked directories like WebKitBuild).
+        (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
+        untracked files/directories (like WebKitBuild).
+
 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
 
         TestRunner::notifyDone() should be safely reentrant