Web process XPC services don't have correct version information in their Info.plist...
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 7 Oct 2012 19:33:49 +0000 (19:33 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 7 Oct 2012 19:33:49 +0000 (19:33 +0000)
https://bugs.webkit.org/show_bug.cgi?id=98619

Reviewed by Anders Carlsson.

* WebProcessService/Info.plist: Added CFBundleGetInfoString, and changed
CFBundleShortVersionString and CFBundleVersion to report the source version.
* WebProcessServiceForWebKitDevelopment/Info.plist: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/WebProcessService/Info.plist
Source/WebKit2/WebProcessServiceForWebKitDevelopment/Info.plist

index bae53f1..0863959 100644 (file)
@@ -1,3 +1,14 @@
+2012-10-07  Dan Bernstein  <mitz@apple.com>
+
+        Web process XPC services don't have correct version information in their Info.plist files
+        https://bugs.webkit.org/show_bug.cgi?id=98619
+
+        Reviewed by Anders Carlsson.
+
+        * WebProcessService/Info.plist: Added CFBundleGetInfoString, and changed
+        CFBundleShortVersionString and CFBundleVersion to report the source version.
+        * WebProcessServiceForWebKitDevelopment/Info.plist: Ditto.
+
 2012-10-06  Dan Bernstein  <mitz@apple.com>
 
         WebKit2 part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
index 404d8a4..c7b0832 100644 (file)
@@ -2,6 +2,8 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
+       <key>CFBundleGetInfoString</key>
+       <string>${BUNDLE_VERSION}, Copyright 2003-2012 Apple Inc.</string>
        <key>CFBundleDevelopmentRegion</key>
        <string>English</string>
        <key>CFBundleExecutable</key>
        <key>CFBundlePackageType</key>
        <string>XPC!</string>
        <key>CFBundleShortVersionString</key>
-       <string>1.0</string>
+       <string>${SHORT_VERSION_STRING}</string>
        <key>CFBundleSignature</key>
        <string>????</string>
        <key>CFBundleVersion</key>
-       <string>1</string>
+       <string>${BUNDLE_VERSION}</string>
        <key>LSFileQuarantineEnabled</key>
        <true/>
        <key>NSPrincipalClass</key>
index b810821..2ab0a9c 100644 (file)
@@ -2,6 +2,8 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
+       <key>CFBundleGetInfoString</key>
+       <string>${BUNDLE_VERSION}, Copyright 2003-2012 Apple Inc.</string>
        <key>CFBundleDevelopmentRegion</key>
        <string>English</string>
        <key>CFBundleExecutable</key>
        <key>CFBundlePackageType</key>
        <string>XPC!</string>
        <key>CFBundleShortVersionString</key>
-       <string>1.0</string>
+       <string>${SHORT_VERSION_STRING}</string>
        <key>CFBundleSignature</key>
        <string>????</string>
        <key>CFBundleVersion</key>
-       <string>1</string>
+       <string>${BUNDLE_VERSION}</string>
        <key>LSFileQuarantineEnabled</key>
        <true/>
        <key>NSPrincipalClass</key>