Take some Xcode advice about turning on additional warnings in ANGLE and gtest
authordarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 30 Sep 2013 05:38:32 +0000 (05:38 +0000)
committerdarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 30 Sep 2013 05:38:32 +0000 (05:38 +0000)
https://bugs.webkit.org/show_bug.cgi?id=122087

Reviewed by Mark Rowe.

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig: Added some warnings that Xcode 5 suggested.

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig: Add some of the warnings that Xcode 5 suggested.
* src/compiler/preprocessor/Tokenizer.l: Defined YY_NO_INPUT so we don't compile
an unused function and get a warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/ThirdParty/ANGLE/ChangeLog
Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.l
Source/ThirdParty/ChangeLog
Source/ThirdParty/gtest/xcode/Config/General.xcconfig

index c6a8ed0..2d46969 100644 (file)
@@ -1,5 +1,16 @@
 2013-09-29  Darin Adler  <darin@apple.com>
 
+        Take some Xcode advice about turning on additional warnings in ANGLE and gtest
+        https://bugs.webkit.org/show_bug.cgi?id=122087
+
+        Reviewed by Mark Rowe.
+
+        * Configurations/Base.xcconfig: Add some of the warnings that Xcode 5 suggested.
+        * src/compiler/preprocessor/Tokenizer.l: Defined YY_NO_INPUT so we don't compile
+        an unused function and get a warning.
+
+2013-09-29  Darin Adler  <darin@apple.com>
+
         Use RenderElement instead of RenderObject in many places
         https://bugs.webkit.org/show_bug.cgi?id=122078
 
index 959b5cb..b738403 100644 (file)
@@ -2,6 +2,9 @@
 
 CLANG_CXX_LANGUAGE_STANDARD = gnu++0x;
 CLANG_CXX_LIBRARY = libc++;
+CLANG_WARN_CONSTANT_CONVERSION = YES;
+CLANG_WARN_EMPTY_BODY = YES;
+CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 DEAD_CODE_STRIPPING = YES;
 DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
 GCC_C_LANGUAGE_STANDARD = gnu99;
@@ -15,12 +18,12 @@ GCC_ENABLE_OBJC_GC_iphonesimulator = NO;
 GCC_ENABLE_OBJC_GC_macosx = supported;
 GCC_ENABLE_SYMBOL_SEPARATION = NO;
 GCC_FAST_OBJC_DISPATCH = YES;
+GCC_INLINES_ARE_PRIVATE_EXTERN = YES;
 GCC_MODEL_TUNING = $(GCC_MODEL_TUNING_$(PLATFORM_NAME));
 GCC_MODEL_TUNING_macosx = G5;
 GCC_OBJC_CALL_CXX_CDTORS = YES;
 GCC_OPTIMIZATION_LEVEL = s;
 GCC_PRECOMPILE_PREFIX_HEADER = NO;
-GCC_INLINES_ARE_PRIVATE_EXTERN = YES;
 GCC_SYMBOLS_PRIVATE_EXTERN = NO;
 GCC_THREADSAFE_STATICS = NO;
 GCC_TREAT_WARNINGS_AS_ERRORS = YES;
@@ -28,6 +31,11 @@ GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
 GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
 GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
 GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
+GCC_WARN_ABOUT_RETURN_TYPE = YES;
+GCC_WARN_UNDECLARED_SELECTOR = YES;
+GCC_WARN_UNINITIALIZED_AUTOS = YES;
+GCC_WARN_UNUSED_FUNCTION = YES;
+GCC_WARN_UNUSED_VARIABLE = YES;
 LINKER_DISPLAYS_MANGLED_NAMES = YES;
 PREBINDING = NO;
 STRIP_INSTALLED_PRODUCT = NO;
index 7c587a3..6ba3790 100644 (file)
@@ -72,6 +72,8 @@ typedef pp::SourceLocation YYLTYPE;
 #define YY_INPUT(buf, result, maxSize) \
     result = yyextra->input.read(buf, maxSize);
 
+#define YY_NO_INPUT
+
 %}
 
 %option noyywrap nounput never-interactive
index 87d8731..d291407 100644 (file)
@@ -1,3 +1,12 @@
+2013-09-29  Darin Adler  <darin@apple.com>
+
+        Take some Xcode advice about turning on additional warnings in ANGLE and gtest
+        https://bugs.webkit.org/show_bug.cgi?id=122087
+
+        Reviewed by Mark Rowe.
+
+        * gtest/xcode/Config/General.xcconfig: Added some warnings that Xcode 5 suggested.
+
 2013-09-06  Alberto Garcia  <berto@igalia.com>
 
         GTest: add support for FreeBSD and Hurd
index a8fc59f..74b6822 100644 (file)
@@ -21,6 +21,14 @@ PREBINDING = NO
 
 // Strictest warning policy
 WARNING_CFLAGS = -Wall -Werror -Wendif-labels -Wnewline-eof -Wno-sign-compare -Wshadow
+CLANG_WARN_CONSTANT_CONVERSION = YES;
+CLANG_WARN_EMPTY_BODY = YES;
+CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
+GCC_WARN_ABOUT_RETURN_TYPE = YES;
+GCC_WARN_UNDECLARED_SELECTOR = YES;
+GCC_WARN_UNINITIALIZED_AUTOS = YES;
+GCC_WARN_UNUSED_FUNCTION = YES;
+GCC_WARN_UNUSED_VARIABLE = YES;
 
 // Work around Xcode bugs by using external strip. See:
 // http://lists.apple.com/archives/Xcode-users/2006/Feb/msg00050.html