<img src=mp4> does not display on ios despite Accept: video/* advertisement
authorjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 30 Apr 2018 23:42:22 +0000 (23:42 +0000)
committerjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 30 Apr 2018 23:42:22 +0000 (23:42 +0000)
https://bugs.webkit.org/show_bug.cgi?id=185029
<rdar://problem/39771989>

Reviewed by Eric Carlson.

Source/WebCore:

Returning "NO" from resourceLoader:shouldWaitForLoadingOfResource: signals that the load failed,
even if the resource request is successfully fulfilled prior to the return. Always return YES in
the case that loading succeeded.

* platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
(-[WebCoreSharedBufferResourceLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):

LayoutTests:

* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/ios/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm

index b7a5131..a3bfe67 100644 (file)
@@ -1,3 +1,13 @@
+2018-04-30  Jer Noble  <jer.noble@apple.com>
+
+        <img src=mp4> does not display on ios despite Accept: video/* advertisement
+        https://bugs.webkit.org/show_bug.cgi?id=185029
+        <rdar://problem/39771989>
+
+        Reviewed by Eric Carlson.
+
+        * platform/ios/TestExpectations:
+
 2018-04-30  Zalan Bujtas  <zalan@apple.com>
 
         REGRESSION(r230914) Selecting text on this apple.com page makes it vanish
index 96df023..0df1244 100644 (file)
@@ -1111,10 +1111,6 @@ fast/viewport/ios/viewport-fit-cover.html [ Pass ]
 fast/viewport/ios/viewport-fit-auto.html [ Pass ]
 fast/css/variables/env/ios [ Pass ]
 
-# This test relies on APIs not available on iOS
-fast/images/animated-image-mp4.html [ Skip ]
-
-
 ###
 # Known failures
 ##
index 2612b06..9191bf3 100644 (file)
@@ -1,3 +1,18 @@
+2018-04-30  Jer Noble  <jer.noble@apple.com>
+
+        <img src=mp4> does not display on ios despite Accept: video/* advertisement
+        https://bugs.webkit.org/show_bug.cgi?id=185029
+        <rdar://problem/39771989>
+
+        Reviewed by Eric Carlson.
+
+        Returning "NO" from resourceLoader:shouldWaitForLoadingOfResource: signals that the load failed,
+        even if the resource request is successfully fulfilled prior to the return. Always return YES in
+        the case that loading succeeded.
+
+        * platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
+        (-[WebCoreSharedBufferResourceLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
+
 2018-04-30  Zalan Bujtas  <zalan@apple.com>
 
         REGRESSION(r230914) Selecting text on this apple.com page makes it vanish
index a45202e..6e53a19 100644 (file)
@@ -203,7 +203,7 @@ SOFT_LINK_POINTER_OPTIONAL(AVFoundation, AVURLAssetUsesNoPersistentCacheKey, NSS
     if ([self canFulfillRequest:loadingRequest]) {
         [self fulfillRequest:loadingRequest];
         if (loadingRequest.finished)
-            return NO;
+            return YES;
     }
 
     [self enqueueRequest:loadingRequest];