Removed unused EventHandler members
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Feb 2017 10:38:00 +0000 (10:38 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Feb 2017 10:38:00 +0000 (10:38 +0000)
https://bugs.webkit.org/show_bug.cgi?id=167723

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-02-02
Reviewed by Yusuke Suzuki.

* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleWheelEvent):
* page/EventHandler.h:
Remove unused members.

* editing/FrameSelection.cpp:
* html/HTMLTextAreaElement.cpp:
* rendering/RenderObject.cpp:
* rendering/RenderSlider.cpp:
Remove unnecessary includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@211555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/editing/FrameSelection.cpp
Source/WebCore/html/HTMLTextAreaElement.cpp
Source/WebCore/page/EventHandler.cpp
Source/WebCore/page/EventHandler.h
Source/WebCore/rendering/RenderObject.cpp
Source/WebCore/rendering/RenderSlider.cpp

index 70b353b..4aacadd 100644 (file)
@@ -1,5 +1,24 @@
 2017-02-02  Joseph Pecoraro  <pecoraro@apple.com>
 
+        Removed unused EventHandler members
+        https://bugs.webkit.org/show_bug.cgi?id=167723
+
+        Reviewed by Yusuke Suzuki.
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::clear):
+        (WebCore::EventHandler::handleWheelEvent):
+        * page/EventHandler.h:
+        Remove unused members.
+
+        * editing/FrameSelection.cpp:
+        * html/HTMLTextAreaElement.cpp:
+        * rendering/RenderObject.cpp:
+        * rendering/RenderSlider.cpp:
+        Remove unnecessary includes.
+
+2017-02-02  Joseph Pecoraro  <pecoraro@apple.com>
+
         Removed unused m_navigationStart from NavigatorGamepad
         https://bugs.webkit.org/show_bug.cgi?id=167722
 
index 713e779..f80b084 100644 (file)
@@ -35,7 +35,6 @@
 #include "Element.h"
 #include "ElementIterator.h"
 #include "Event.h"
-#include "EventHandler.h"
 #include "EventNames.h"
 #include "FloatQuad.h"
 #include "FocusController.h"
index 35a42b3..44e0330 100644 (file)
@@ -32,7 +32,6 @@
 #include "Editor.h"
 #include "ElementChildIterator.h"
 #include "Event.h"
-#include "EventHandler.h"
 #include "EventNames.h"
 #include "FormController.h"
 #include "FormDataList.h"
index ee4e772..2cf4867 100644 (file)
@@ -450,7 +450,6 @@ void EventHandler::clear()
     m_originatingTouchPointTargetKey = 0;
 #endif
     m_maxMouseMovedDuration = 0;
-    m_baseEventType = PlatformEvent::NoType;
     m_didStartDrag = false;
 }
 
@@ -2694,7 +2693,7 @@ bool EventHandler::handleWheelEvent(const PlatformWheelEvent& event)
     // FIXME: It should not be necessary to do this mutation here.
     // Instead, the handlers should know convert vertical scrolls appropriately.
     PlatformWheelEvent adjustedEvent = event;
-    if (m_baseEventType == PlatformEvent::NoType && shouldTurnVerticalTicksIntoHorizontal(result, event))
+    if (shouldTurnVerticalTicksIntoHorizontal(result, event))
         adjustedEvent = event.copyTurningVerticalTicksIntoHorizontalTicks();
 
     platformRecordWheelEvent(adjustedEvent);
index a82d7cd..db0ef21 100644 (file)
@@ -491,8 +491,6 @@ private:
     LayoutPoint m_dragStartPosition;
 #endif
 
-    bool m_panScrollButtonPressed { false };
-
     Timer m_hoverTimer;
 
 #if ENABLE(CURSOR_SUPPORT)
@@ -583,7 +581,6 @@ private:
 #endif
 
     double m_maxMouseMovedDuration { 0 };
-    PlatformEvent::Type m_baseEventType { PlatformEvent::NoType };
     bool m_didStartDrag { false };
     bool m_isHandlingWheelEvent { false };
 
index 46c4bb7..374f05d 100644 (file)
@@ -29,7 +29,6 @@
 
 #include "AXObjectCache.h"
 #include "AnimationController.h"
-#include "EventHandler.h"
 #include "FloatQuad.h"
 #include "FlowThreadController.h"
 #include "FrameSelection.h"
index 6ea9690..0dd07d9 100644 (file)
@@ -24,7 +24,6 @@
 #include "CSSPropertyNames.h"
 #include "Document.h"
 #include "Event.h"
-#include "EventHandler.h"
 #include "Frame.h"
 #include "HTMLInputElement.h"
 #include "HTMLNames.h"