webkitRegionLayoutUpdate is incorrectly named
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Nov 2012 22:32:07 +0000 (22:32 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Nov 2012 22:32:07 +0000 (22:32 +0000)
https://bugs.webkit.org/show_bug.cgi?id=100335

Reviewed by Ojan Vafai.

Source/WebCore:

DOM event names are supposed to be lower case.

* dom/EventNames.h:
(WebCore):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Update tests to use the proper name.

* fast/regions/webkit-named-flow-event-add-to-flow.html:
* fast/regions/webkit-named-flow-event-no-regions.html:
* fast/regions/webkit-named-flow-event-remove-from-dom.html:
* fast/regions/webkit-named-flow-event-remove-from-flow.html:
* fast/regions/webkit-named-flow-event-target.html:
* fast/regions/webkit-named-flow-event-to-null.html:
* fast/regions/webkit-named-flow-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/regions/webkit-named-flow-event-add-to-flow.html
LayoutTests/fast/regions/webkit-named-flow-event-no-regions.html
LayoutTests/fast/regions/webkit-named-flow-event-remove-from-dom.html
LayoutTests/fast/regions/webkit-named-flow-event-remove-from-flow.html
LayoutTests/fast/regions/webkit-named-flow-event-target.html
LayoutTests/fast/regions/webkit-named-flow-event-to-null.html
LayoutTests/fast/regions/webkit-named-flow-event.html
Source/WebCore/ChangeLog
Source/WebCore/dom/EventNames.h
Source/WebCore/dom/WebKitNamedFlow.cpp

index 24f7f61..2690790 100644 (file)
@@ -1,3 +1,20 @@
+2012-11-05  Adam Barth  <abarth@webkit.org>
+
+        webkitRegionLayoutUpdate is incorrectly named
+        https://bugs.webkit.org/show_bug.cgi?id=100335
+
+        Reviewed by Ojan Vafai.
+
+        Update tests to use the proper name.
+
+        * fast/regions/webkit-named-flow-event-add-to-flow.html:
+        * fast/regions/webkit-named-flow-event-no-regions.html:
+        * fast/regions/webkit-named-flow-event-remove-from-dom.html:
+        * fast/regions/webkit-named-flow-event-remove-from-flow.html:
+        * fast/regions/webkit-named-flow-event-target.html:
+        * fast/regions/webkit-named-flow-event-to-null.html:
+        * fast/regions/webkit-named-flow-event.html:
+
 2012-11-05  Stephen White  <senorblanco@chromium.org>
 
         Remove fast/forms/week-multiple-fields from
index e8a4db7..facdc27 100644 (file)
@@ -50,7 +50,7 @@
         shouldBeEqualToString("event.target.name", "article");
         
         if (++count > 1) {
-            event.target.removeEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+            event.target.removeEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
             
             // this should be reached after region_2 is added to flow
             finishJSTest();
@@ -62,7 +62,7 @@
 
     function startTest() {
         var flow = getFlowByName("article");
-        flow.addEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+        flow.addEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
         
         debug("Flow content");
         flowContent("region_1", "article");
index 6e1dcd2..27fe632 100644 (file)
@@ -53,7 +53,7 @@
     function regionLayoutUpdated(event) {
         shouldBeEqualToString("event.target.name", "article");
         if (++count > 1) {
-           event.target.removeEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+           event.target.removeEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
            finishJSTest();
            return;
         }
@@ -68,7 +68,7 @@
 
     function startTest() {
         var flow = getFlowByName("article");
-        flow.addEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+        flow.addEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
 
         debug("Flow content");
         flowContent("article");
index 1009543..02589e6 100644 (file)
@@ -54,7 +54,7 @@
     function regionLayoutUpdated(event) {
         shouldBeEqualToString("event.target.name", "article");
         if (++count > 1) {
-           event.target.removeEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+           event.target.removeEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
            // this should be reached after region_2 is removed from DOM
            finishJSTest();
            return;
@@ -67,7 +67,7 @@
     
     function startTest() {
         var flow = getFlowByName("article");
-        flow.addEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+        flow.addEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
         
         debug("Flow content");
         flowContent("article");
index 5077c6a..028d448 100644 (file)
@@ -52,7 +52,7 @@
     function regionLayoutUpdated(event) {
         shouldBeEqualToString("event.target.name", "article");
         if (++count > 1) {
-           event.target.removeEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+           event.target.removeEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
            // this should be reached after region_2 is removed from DOM
            finishJSTest();
            return;
@@ -65,7 +65,7 @@
     
     function startTest() {
         var flow = getFlowByName("article");
-        flow.addEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+        flow.addEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
         
         debug("Flow content");
         flowContent("article");
index c6b86eb..ef6bb14 100644 (file)
@@ -83,7 +83,7 @@ function flowThreadUpdated(event) {
 
     if (updatedCount == 2) {
        shouldBeTrue("recreated");
-       event.target.removeEventListener("webkitRegionLayoutUpdate", flowThreadUpdated);
+       event.target.removeEventListener("webkitregionlayoutupdate", flowThreadUpdated);
        makeFlowNull();
        finishJSTest();
        return;
@@ -98,7 +98,7 @@ function flowThreadUpdated(event) {
 
 function startTest() {    
     var flowThread = getFlowByName("article");
-    flowThread.addEventListener("webkitRegionLayoutUpdate", flowThreadUpdated);
+    flowThread.addEventListener("webkitregionlayoutupdate", flowThreadUpdated);
     
     debug("Flow content");
     flowContent("article");
index f490e32..53f5dec 100644 (file)
@@ -56,7 +56,7 @@ if (window.testRunner) {
     function regionLayoutUpdated(event) {
         shouldBeEqualToString("event.target.name", "article");
         if (++count > 1) {
-           event.target.removeEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+           event.target.removeEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
            layoutUpdateDispatchedForNullFlow = true;
            return;
         }
@@ -81,7 +81,7 @@ if (window.testRunner) {
     
     function startTest() {
         var flow = getFlowByName("article");
-        flow.addEventListener("webkitRegionLayoutUpdate", regionLayoutUpdated);
+        flow.addEventListener("webkitregionlayoutupdate", regionLayoutUpdated);
         
         debug("Flow content");
         flowContent("article");
index 9308f7e..766e209 100644 (file)
     
     function flowThreadUpdated(event) {
         shouldBeEqualToString("event.target.name", "article");
-        event.target.removeEventListener("webkitRegionLayoutUpdate", flowThreadUpdated);
+        event.target.removeEventListener("webkitregionlayoutupdate", flowThreadUpdated);
         
         finishJSTest();
     }
     
     function startTest() {    
         var flowThread = getFlowByName("article");
-        flowThread.addEventListener("webkitRegionLayoutUpdate", flowThreadUpdated);
+        flowThread.addEventListener("webkitregionlayoutupdate", flowThreadUpdated);
         
         debug("Flow content");
         flowContent("article");
index 867ca34..da11f6c 100644 (file)
@@ -1,5 +1,19 @@
 2012-11-05  Adam Barth  <abarth@webkit.org>
 
+        webkitRegionLayoutUpdate is incorrectly named
+        https://bugs.webkit.org/show_bug.cgi?id=100335
+
+        Reviewed by Ojan Vafai.
+
+        DOM event names are supposed to be lower case.
+
+        * dom/EventNames.h:
+        (WebCore):
+        * dom/WebKitNamedFlow.cpp:
+        (WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
+
+2012-11-05  Adam Barth  <abarth@webkit.org>
+
         [V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
         https://bugs.webkit.org/show_bug.cgi?id=101110
 
index 09b9ae7..9ed7c7c 100644 (file)
@@ -235,7 +235,7 @@ namespace WebCore {
     macro(webkitpointerlockchange) \
     macro(webkitpointerlockerror) \
     \
-    macro(webkitRegionLayoutUpdate) \
+    macro(webkitregionlayoutupdate) \
     \
     macro(webkitnetworkinfochange) \
     \
index 593e51a..b9debd9 100644 (file)
@@ -198,7 +198,7 @@ void WebKitNamedFlow::dispatchRegionLayoutUpdateEvent()
     ASSERT(!NoEventDispatchAssertion::isEventDispatchForbidden());
     ASSERT(m_parentFlowThread);
 
-    RefPtr<Event> event = UIEvent::create(eventNames().webkitRegionLayoutUpdateEvent, false, false, m_parentFlowThread->document()->defaultView(), 0);
+    RefPtr<Event> event = UIEvent::create(eventNames().webkitregionlayoutupdateEvent, false, false, m_parentFlowThread->document()->defaultView(), 0);
 
     dispatchEvent(event);
 }