Correct '--show-webview' option for Tiled Drawing tests
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 May 2015 05:22:52 +0000 (05:22 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 May 2015 05:22:52 +0000 (05:22 +0000)
https://bugs.webkit.org/show_bug.cgi?id=144621

Reviewed by Simon Fraser.

The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
sure that the state of the '--show-webview' option was propagated to this additional view creation routine.

* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/WebKitTestRunner/mac/TestControllerMac.mm

index 82dd551..1cfa6ce 100644 (file)
@@ -1,3 +1,17 @@
+2015-05-04  Brent Fulgham  <bfulgham@apple.com>
+
+        Correct '--show-webview' option for Tiled Drawing tests
+        https://bugs.webkit.org/show_bug.cgi?id=144621
+
+        Reviewed by Simon Fraser.
+
+        The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
+        sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
+
+        * WebKitTestRunner/mac/TestControllerMac.mm:
+        (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
+        WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
+
 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
 
         Large array shouldn't be slow
index 2aa96ed..eda456f 100644 (file)
@@ -107,6 +107,10 @@ void TestController::platformConfigureViewForTest(const TestInvocation& test)
     auto useRemoteLayerTreeValue = adoptWK(WKBooleanCreate(shouldUseRemoteLayerTree()));
     WKDictionarySetItem(viewOptions.get(), useRemoteLayerTreeKey.get(), useRemoteLayerTreeValue.get());
 
+    auto shouldShowWebViewKey = adoptWK(WKStringCreateWithUTF8CString("ShouldShowWebView"));
+    auto shouldShowWebViewValue = adoptWK(WKBooleanCreate(shouldShowWebView()));
+    WKDictionarySetItem(viewOptions.get(), shouldShowWebViewKey.get(), shouldShowWebViewValue.get());
+
     ensureViewSupportsOptions(viewOptions.get());
 
     if (!test.urlContains("contentextensions/"))