2011-01-24 Yury Semikhatsky <yurys@chromium.org>
authoryurys@chromium.org <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Jan 2011 15:20:30 +0000 (15:20 +0000)
committeryurys@chromium.org <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Jan 2011 15:20:30 +0000 (15:20 +0000)
        Reviewed by Pavel Feldman.

        Web Inspector: [JSC] remove ScriptDebugServer::pageCreated
        https://bugs.webkit.org/show_bug.cgi?id=53007

        It's impossible to create "provisional" inspector for pages which are
        not yet created so there is no need to listen for page creation in ScriptDebugServer.

        * bindings/js/ScriptDebugServer.cpp:
        * bindings/js/ScriptDebugServer.h:
        * page/Page.cpp:
        (WebCore::Page::Page):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/bindings/js/ScriptDebugServer.cpp
Source/WebCore/bindings/js/ScriptDebugServer.h
Source/WebCore/page/Page.cpp

index 1231f03..3686e14 100644 (file)
@@ -1,3 +1,18 @@
+2011-01-24  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: [JSC] remove ScriptDebugServer::pageCreated
+        https://bugs.webkit.org/show_bug.cgi?id=53007
+
+        It's impossible to create "provisional" inspector for pages which are
+        not yet created so there is no need to listen for page creation in ScriptDebugServer.
+
+        * bindings/js/ScriptDebugServer.cpp:
+        * bindings/js/ScriptDebugServer.h:
+        * page/Page.cpp:
+        (WebCore::Page::Page):
+
 2011-01-24  Pavel Podivilov  <podivilov@chromium.org>
 
         Reviewed by Pavel Feldman.
index c3a3fa8..33a318c 100644 (file)
@@ -117,15 +117,6 @@ void ScriptDebugServer::removeListener(ScriptDebugListener* listener, Page* page
     didRemoveListener(page);
 }
 
-void ScriptDebugServer::pageCreated(Page* page)
-{
-    ASSERT_ARG(page, page);
-
-    if (!hasListenersInterestedInPage(page))
-        return;
-    page->setDebugger(this);
-}
-
 bool ScriptDebugServer::isDebuggerAlwaysEnabled()
 {
     return false;
index c0b44c7..1e38819 100644 (file)
@@ -93,8 +93,6 @@ public:
 
     JavaScriptCallFrame* currentCallFrame();
 
-    void pageCreated(Page*);
-
     bool isDebuggerAlwaysEnabled();
 
 private:
index 012a9be..8550681 100644 (file)
 #include "StorageNamespace.h"
 #endif
 
-#if ENABLE(JAVASCRIPT_DEBUGGER)
-#include "ScriptDebugServer.h"
-#endif
-
 #if ENABLE(WML)
 #include "WMLPageState.h"
 #endif
@@ -180,10 +176,6 @@ Page::Page(const PageClients& pageClients)
         m_pluginHalter->setPluginAllowedRunTime(m_settings->pluginAllowedRunTime());
     }
 
-#if ENABLE(JAVASCRIPT_DEBUGGER)
-    ScriptDebugServer::shared().pageCreated(this);
-#endif
-
 #ifndef NDEBUG
     pageCounter.increment();
 #endif