Performance dashboard should show added iterations due failed build requests.
authordewei_zhu@apple.com <dewei_zhu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Oct 2018 03:43:47 +0000 (03:43 +0000)
committerdewei_zhu@apple.com <dewei_zhu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Oct 2018 03:43:47 +0000 (03:43 +0000)
https://bugs.webkit.org/show_bug.cgi?id=190419

Reviewed by Ryosuke Niwa.

Added UI to show added build requests due to previous failed build requests.
Updated the retry/bisect button to default to initial repetition count when test group is created.

* public/v3/pages/analysis-task-page.js: Added a div to show added build requests.
Retry and bisect button should default to initial repetion count.
(AnalysisTaskTestGroupPane.prototype._renderCurrentTestGroup):
(AnalysisTaskTestGroupPane.cssTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/perf.webkit.org/ChangeLog
Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js

index 017e4d2..1db0d8b 100644 (file)
@@ -1,3 +1,18 @@
+2018-10-09  Dewei Zhu  <dewei_zhu@apple.com>
+
+        Performance dashboard should show added iterations due failed build requests.
+        https://bugs.webkit.org/show_bug.cgi?id=190419
+
+        Reviewed by Ryosuke Niwa.
+
+        Added UI to show added build requests due to previous failed build requests.
+        Updated the retry/bisect button to default to initial repetition count when test group is created.
+
+        * public/v3/pages/analysis-task-page.js: Added a div to show added build requests.
+        Retry and bisect button should default to initial repetion count.
+        (AnalysisTaskTestGroupPane.prototype._renderCurrentTestGroup):
+        (AnalysisTaskTestGroupPane.cssTemplate):
+
 2018-10-09  Ryosuke Niwa  <rniwa@webkit.org>
 
         ManifestGenerator shouldn't need more than 1GB of memory or run for 30 seconds
index 0f7089f..8280daa 100644 (file)
@@ -369,11 +369,14 @@ class AnalysisTaskTestGroupPane extends ComponentBase {
             this._testGroupMap.get(currentGroup).listItem.classList.add('selected');
 
         if (currentGroup) {
-            this.part('retry-form').setRepetitionCount(currentGroup.repetitionCount());
-            this.part('bisect-form').setRepetitionCount(currentGroup.repetitionCount());
+            this.part('retry-form').setRepetitionCount(currentGroup.initialRepetitionCount());
+            this.part('bisect-form').setRepetitionCount(currentGroup.initialRepetitionCount());
+            const summary = `${currentGroup.initialRepetitionCount()} requested, ${currentGroup.repetitionCount() - currentGroup.initialRepetitionCount()} added due to failures.`;
+            this.content('status-summary').innerHTML = summary;
         }
         this.content('retry-form').style.display = currentGroup ? null : 'none';
         this.content('bisect-form').style.display = currentGroup && this._bisectingCommitSetByTestGroup.get(currentGroup) ? null : 'none';
+        this.content('status-summary').style.display = currentGroup && currentGroup.repetitionCount() > currentGroup.initialRepetitionCount() ? null : 'none';
 
         const hideButton = this.content('hide-button');
         hideButton.textContent = currentGroup && currentGroup.isHidden() ? 'Unhide' : 'Hide';
@@ -389,6 +392,7 @@ class AnalysisTaskTestGroupPane extends ComponentBase {
             <div id="test-group-details">
                 <test-group-results-viewer id="results-viewer"></test-group-results-viewer>
                 <test-group-revision-table id="revision-table"></test-group-revision-table>
+                <div id="status-summary" class="summary"></div>
                 <test-group-form id="retry-form">Retry</test-group-form>
                 <test-group-form id="bisect-form">Bisect</test-group-form>
                 <button id="hide-button">Hide</button>
@@ -451,6 +455,10 @@ class AnalysisTaskTestGroupPane extends ComponentBase {
                 background: #eee;
             }
 
+            div.summary {
+                padding-left: 1rem;
+            }
+
             #test-group-details {
                 display: table-cell;
                 margin-bottom: 1rem;