REGRESSION: fast/css/paint-order.html and fast/css/paint-order-shadow.html are failing
authorpvollan@apple.com <pvollan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 26 Oct 2019 00:21:39 +0000 (00:21 +0000)
committerpvollan@apple.com <pvollan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 26 Oct 2019 00:21:39 +0000 (00:21 +0000)
https://bugs.webkit.org/show_bug.cgi?id=203313
<rdar://problem/52557916>

Reviewed by Alexey Proskuryakov.

Catalina introduced a regression, causing these tests to fail. This was not a regression related to the feature these
tests are testing, but a regression related to the rendering position and size of a specific glyph. Given this, the
tests are changed to take this into consideration, making them pass both on Catalina and previous versions of the OS.

* fast/css/paint-order-expected.html:
* fast/css/paint-order-shadow-expected.html:
* fast/css/paint-order-shadow.html:
* fast/css/paint-order.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/css/paint-order-expected.html
LayoutTests/fast/css/paint-order-shadow-expected.html
LayoutTests/fast/css/paint-order-shadow.html
LayoutTests/fast/css/paint-order.html
LayoutTests/platform/mac/TestExpectations

index 7d8a3b0..7277a00 100644 (file)
@@ -1,3 +1,21 @@
+2019-10-25  Per Arne Vollan  <pvollan@apple.com>
+
+        REGRESSION: fast/css/paint-order.html and fast/css/paint-order-shadow.html are failing
+        https://bugs.webkit.org/show_bug.cgi?id=203313
+        <rdar://problem/52557916>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Catalina introduced a regression, causing these tests to fail. This was not a regression related to the feature these
+        tests are testing, but a regression related to the rendering position and size of a specific glyph. Given this, the
+        tests are changed to take this into consideration, making them pass both on Catalina and previous versions of the OS.
+
+        * fast/css/paint-order-expected.html:
+        * fast/css/paint-order-shadow-expected.html:
+        * fast/css/paint-order-shadow.html:
+        * fast/css/paint-order.html:
+        * platform/mac/TestExpectations:
+
 2019-10-25  Truitt Savell  <tsavell@apple.com>
 
         Adding expectations for editing/pasteboard/smart-paste-paragraph-003.html
index 44dad7a..3c6828c 100644 (file)
@@ -4,36 +4,36 @@
 <head>
     <style>
         div {
-            position: absolute;
-            font-size: 80px;
+            font-size: 100px;
             color: gray;
+            width: 100px;
         }
 
         .test-stroke {
             text-shadow: none;
-            -webkit-text-stroke: 25px red;
+            -webkit-text-stroke: 60px red;
             
             /* Clip used to isolate the stroke */
-            -webkit-clip-path: inset(20px 55px 30px 15px);
+            -webkit-clip-path: inset(55px 35px 55px 35px);
         }        
 
         .fill-grey {
             text-shadow: none;
         
             /* Clip used to isolate the stroke */
-            -webkit-clip-path: inset(20px 55px 30px 15px);
+            -webkit-clip-path: inset(55px 35px 55px 35px);
         }
 
     </style>
 </head>
 <body>
 
-<div class="test-stroke" style="paint-order: fill; top: 0px">&#x25fc;</div>
-<div class="test-stroke" style="paint-order: fill markers; top: 100px">&#x25fc;</div>
-<div class="fill-grey" style="paint-order: stroke; top: 200px">&#x25fc;</div>
-<div class="fill-grey" style="paint-order: stroke markers; top: 300px">&#x25fc;</div>
-<div class="test-stroke" style="paint-order: markers; top: 400px">&#x25fc;</div>
-<div class="fill-grey" style="paint-order: markers stroke; top: 500px">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: fill;">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: fill markers;">&#x25fc;</div>
+<div class="fill-grey" style="paint-order: stroke;">&#x25fc;</div>
+<div class="fill-grey" style="paint-order: stroke markers;">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: markers;">&#x25fc;</div>
+<div class="fill-grey" style="paint-order: markers stroke;">&#x25fc;</div>
 
 </body>
 </html>
index fa3b48a..123f4ac 100644 (file)
@@ -4,29 +4,34 @@
 <head>
     <style>
         div {
-            position: absolute;
-            font-size: 80px;
+            font-size: 100px;
             color: gray;
             width: 200px;
-            left: 0px;
         }
 
+        .test-stroke {
+            text-shadow: 100px 0 0 rgba(0, 0, 0, 0.5);
+            -webkit-text-stroke: 70px red;
+            
+            /* Clip used to isolate the stroke */
+            -webkit-clip-path: inset(50px 40px 50px 140px);
+        }
         .bg-color-gray {
             background-color: gray;
 
             /* Clip used to isolate a part of the shadow */
-            -webkit-clip-path: inset(30px 75px 30px 115px);
+            -webkit-clip-path: inset(50px 40px 50px 140px);
         }
     </style>
 </head>
 <body>
 
-<div class="bg-color-gray" style="paint-order: fill; top: 0px">&#x25fc;</div>
-<div class="bg-color-gray" style="paint-order: fill markers; top: 100px">&#x25fc;</div>
-<div class="bg-color-gray" style="paint-order: stroke; top: 200px">&#x25fc;</div>
-<div class="bg-color-gray" style="paint-order: stroke markers; top: 300px">&#x25fc;</div>
-<div class="bg-color-gray" style="paint-order: markers; top: 400px">&#x25fc;</div>
-<div class="bg-color-gray" style="paint-order: markers stroke; top: 500px">&#x25fc;</div>
+<div class="bg-color-gray" style="paint-order: fill;">&#x25fc;</div>
+<div class="bg-color-gray" style="paint-order: fill markers;">&#x25fc;</div>
+<div class="bg-color-gray" style="paint-order: stroke;">&#x25fc;</div>
+<div class="bg-color-gray" style="paint-order: stroke markers;">&#x25fc;</div>
+<div class="bg-color-gray" style="paint-order: markers;">&#x25fc;</div>
+<div class="bg-color-gray" style="paint-order: markers stroke;">&#x25fc;</div>
 
 </body>
 </html>
index 482756e..58d555b 100644 (file)
@@ -4,30 +4,28 @@
 <head>
     <style>
         div {
-            position: absolute;
-            font-size: 80px;
+            font-size: 100px;
             color: gray;
             width: 200px;
-            left: 0px;
         }
 
         .test-stroke {
             text-shadow: 100px 0 0 rgba(0, 0, 0, 0.5);
-            -webkit-text-stroke: 25px red;
+            -webkit-text-stroke: 70px red;
 
-            /* Clip used to isolate a part of the shadow */
-            -webkit-clip-path: inset(30px 75px 30px 115px);
+            /* Clip used to isolate the shadow */
+            -webkit-clip-path: inset(50px 40px 50px 140px);
         }
     </style>
 </head>
 <body>
 
-<div class="test-stroke" style="paint-order: fill; top: 0px">&#x25fc;</div>
-<div class="test-stroke" style="paint-order: fill markers; top: 100px">&#x25fc;</div>
-<div class="test-stroke" style="paint-order: stroke; top: 200px">&#x25fc;</div>
-<div class="test-stroke" style="paint-order: stroke markers; top: 300px">&#x25fc;</div>
-<div class="test-stroke" style="paint-order: markers; top: 400px">&#x25fc;</div>
-<div class="test-stroke" style="paint-order: markers stroke; top: 500px">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: fill;">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: fill markers;">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: stroke;">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: stroke markers;">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: markers;">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: markers stroke;">&#x25fc;</div>
 
 </body>
 </html>
index 068f312..2b933f9 100644 (file)
@@ -4,28 +4,28 @@
 <head>
     <style>
         div {
-            position: absolute;
-            font-size: 80px;
+            font-size: 100px;
             color: gray;
+            width: 100px;
         }
 
         .test-stroke {
             text-shadow: none;
-            -webkit-text-stroke: 25px red;
+            -webkit-text-stroke: 60px red;
             
             /* Clip used to isolate the stroke */
-            -webkit-clip-path: inset(20px 55px 30px 15px);
+            -webkit-clip-path: inset(55px 35px 55px 35px);
         }
     </style>
 </head>
 <body>
 
-<div class="test-stroke" style="paint-order: fill; top: 0px">&#x25fc;</div>
-<div class="test-stroke" style="paint-order: fill markers; top: 100px">&#x25fc;</div>
-<div class="test-stroke" style="paint-order: stroke; top: 200px">&#x25fc;</div>
-<div class="test-stroke" style="paint-order: stroke markers; top: 300px">&#x25fc;</div>
-<div class="test-stroke" style="paint-order: markers; top: 400px">&#x25fc;</div>
-<div class="test-stroke" style="paint-order: markers stroke; top: 500px">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: fill;">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: fill markers;">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: stroke;">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: stroke markers;">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: markers;">&#x25fc;</div>
+<div class="test-stroke" style="paint-order: markers stroke;">&#x25fc;</div>
 
 </body>
 </html>
index 9415111..2d24b92 100644 (file)
@@ -1964,10 +1964,6 @@ webkit.org/b/200258 [ Debug ] imported/w3c/web-platform-tests/wasm/jsapi/interfa
 
 webkit.org/b/200128 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_timeupdate_on_seek.html [ Timeout Pass ]
 
-# rdar://52557916 (REGRESSION: fast/css/paint-order.html and fast/css/paint-order-shadow.html are failing)
-[ Catalina+ ] fast/css/paint-order.html [ ImageOnlyFailure ]
-[ Catalina+ ] fast/css/paint-order-shadow.html [ ImageOnlyFailure ]
-
 webkit.org/b/181837 [ Release ] imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html [ Pass Failure ]
 
 webkit.org/b/199124 http/tests/appcache/remove-cache.html [ Pass Failure ]