Web Inspector: clicking Computed Styles sidebar "Show All" checkbox doesn't trigger...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 7 Sep 2016 17:24:14 +0000 (17:24 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 7 Sep 2016 17:24:14 +0000 (17:24 +0000)
https://bugs.webkit.org/show_bug.cgi?id=161652

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-09-07
Reviewed by Brian Burg.

* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._iterateOverProperties):
Fixed style issues from r205518 <webkit.org/b/161405>.

* UserInterface/Views/ComputedStyleDetailsPanel.js:
(WebInspector.ComputedStyleDetailsPanel.prototype.get regionFlow):
(WebInspector.ComputedStyleDetailsPanel.prototype.get contentFlow):
(WebInspector.ComputedStyleDetailsPanel.prototype.get containerRegions):
Added missing space between semicolon and curly-brace.

(WebInspector.ComputedStyleDetailsPanel.prototype._computedStyleShowAllCheckboxValueChanged):
Added updateLayout call to resize and repopulate the CodeMirror instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@205555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js
Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js

index 413375b..e0edea9 100644 (file)
@@ -1,3 +1,23 @@
+2016-09-07  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        Web Inspector: clicking Computed Styles sidebar "Show All" checkbox doesn't trigger relayout of Properties section
+        https://bugs.webkit.org/show_bug.cgi?id=161652
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+        (WebInspector.CSSStyleDeclarationTextEditor.prototype._iterateOverProperties):
+        Fixed style issues from r205518 <webkit.org/b/161405>.
+
+        * UserInterface/Views/ComputedStyleDetailsPanel.js:
+        (WebInspector.ComputedStyleDetailsPanel.prototype.get regionFlow):
+        (WebInspector.ComputedStyleDetailsPanel.prototype.get contentFlow):
+        (WebInspector.ComputedStyleDetailsPanel.prototype.get containerRegions):
+        Added missing space between semicolon and curly-brace.
+
+        (WebInspector.ComputedStyleDetailsPanel.prototype._computedStyleShowAllCheckboxValueChanged):
+        Added updateLayout call to resize and repopulate the CodeMirror instance.
+
 2016-09-07  Chris Dumez  <cdumez@apple.com>
 
         Drop legacy canvas.probablySupportsContext()
index c6de560..a935220 100644 (file)
@@ -1219,6 +1219,13 @@ WebInspector.CSSStyleDeclarationTextEditor = class CSSStyleDeclarationTextEditor
                         return false;
 
                     break;
+
+                case WebInspector.CSSStyleDeclarationTextEditor.PropertyVisibilityMode.ShowAll:
+                    break;
+
+                default:
+                    console.error("Invalid property visibility mode");
+                    break;
                 }
 
                 return !property.implicit || this._showsImplicitProperties || property.canonicalName in this._alwaysShowPropertyNames;
@@ -1227,7 +1234,7 @@ WebInspector.CSSStyleDeclarationTextEditor = class CSSStyleDeclarationTextEditor
 
         properties = properties.filter(filterFunction);
         if (this._sortProperties)
-                properties.sort((a, b) => a.name.localeCompare(b.name));
+            properties.sort((a, b) => a.name.localeCompare(b.name));
 
         this._shownProperties = properties;
 
index d0c2ee3..3035604 100644 (file)
@@ -36,7 +36,7 @@ WebInspector.ComputedStyleDetailsPanel = class ComputedStyleDetailsPanel extends
 
     // Public
 
-    get regionFlow() { return this._regionFlow;}
+    get regionFlow() { return this._regionFlow; }
     set regionFlow(regionFlow)
     {
         this._regionFlow = regionFlow;
@@ -45,7 +45,7 @@ WebInspector.ComputedStyleDetailsPanel = class ComputedStyleDetailsPanel extends
         this._updateFlowNamesSectionVisibility();
     }
 
-    get contentFlow() { return this._contentFlow;}
+    get contentFlow() { return this._contentFlow; }
     set contentFlow(contentFlow)
     {
         this._contentFlow = contentFlow;
@@ -54,7 +54,7 @@ WebInspector.ComputedStyleDetailsPanel = class ComputedStyleDetailsPanel extends
         this._updateFlowNamesSectionVisibility();
     }
 
-    get containerRegions() { return this._containerRegions;}
+    get containerRegions() { return this._containerRegions; }
     set containerRegions(regions)
     {
         this._containerRegions = regions;
@@ -224,9 +224,10 @@ WebInspector.ComputedStyleDetailsPanel = class ComputedStyleDetailsPanel extends
 
     _computedStyleShowAllCheckboxValueChanged(event)
     {
-        var checked = this._computedStyleShowAllCheckbox.checked;
+        let checked = this._computedStyleShowAllCheckbox.checked;
         this._computedStyleShowAllSetting.value = checked;
         this._propertiesTextEditor.showsImplicitProperties = checked;
+        this._propertiesTextEditor.updateLayout();
     }
 
     _handlePropertiesSectionCollapsedStateChanged(event)