[GTK] accessibility/aria-link-supports-press.html is failing
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Nov 2013 10:24:39 +0000 (10:24 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Nov 2013 10:24:39 +0000 (10:24 +0000)
https://bugs.webkit.org/show_bug.cgi?id=98355

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Tools:

Checking "jump" action for link elements. Action "jump" occurs when a link
element is pressed/clicked.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isPressActionSupported):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isPressActionSupported):

LayoutTests:

Removed failure expectation.

* platform/gtk/TestExpectations: test is no longer failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
Tools/ChangeLog
Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp

index 08ab3e9..ff3d7d2 100644 (file)
@@ -1,3 +1,14 @@
+2013-11-08  Krzysztof Czech  <k.czech@samsung.com>
+
+        [GTK] accessibility/aria-link-supports-press.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=98355
+
+        Reviewed by Mario Sanchez Prada.
+
+        Removed failure expectation.
+
+        * platform/gtk/TestExpectations: test is no longer failing.
+
 2013-11-08  Andreas Kling  <akling@apple.com>
 
         Add back expectation for test that went missing in r158813.
index c3ff197..1e81152 100644 (file)
@@ -875,7 +875,6 @@ webkit.org/b/73766 css3/unicode-bidi-isolate-aharon-failing.html [ ImageOnlyFail
 webkit.org/b/79757 fast/selectors/selection-window-inactive.html [ ImageOnlyFailure ]
 
 webkit.org/b/121684 accessibility/aria-describedby-on-input.html [ Failure ]
-webkit.org/b/98355 accessibility/aria-link-supports-press.html [ Failure ]
 webkit.org/b/98357 accessibility/aria-readonly.html [ Failure ]
 webkit.org/b/98359 accessibility/aria-text-role.html [ Failure ]
 webkit.org/b/98363 accessibility/canvas-fallback-content-2.html [ Failure ]
index 9bf2d08..ad4722d 100644 (file)
@@ -1,3 +1,18 @@
+2013-11-08  Krzysztof Czech  <k.czech@samsung.com>
+
+        [GTK] accessibility/aria-link-supports-press.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=98355
+
+        Reviewed by Mario Sanchez Prada.
+
+        Checking "jump" action for link elements. Action "jump" occurs when a link 
+        element is pressed/clicked.
+
+        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+        (AccessibilityUIElement::isPressActionSupported):
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+        (WTR::AccessibilityUIElement::isPressActionSupported):
+
 2013-11-08  Przemyslaw Szymanski  <p.szymanski3@samsung.com>
 
         [JHBUILD] Jhbuild Makefile build bug workaround
index cd0c9eb..2058752 100644 (file)
@@ -907,7 +907,8 @@ bool AccessibilityUIElement::isPressActionSupported()
     if (!ATK_IS_ACTION(m_element))
         return false;
 
-    return equalIgnoringCase(atk_action_get_name(ATK_ACTION(m_element), 0), String("press"));
+    const gchar* actionName = atk_action_get_name(ATK_ACTION(m_element), 0);
+    return equalIgnoringCase(actionName, String("press")) || equalIgnoringCase(actionName, String("jump"));
 }
 
 bool AccessibilityUIElement::isIncrementActionSupported()
index 72a749d..c5eba47 100644 (file)
@@ -1010,7 +1010,8 @@ bool AccessibilityUIElement::isPressActionSupported()
     if (!ATK_IS_ACTION(m_element.get()))
         return false;
 
-    return equalIgnoringCase(atk_action_get_name(ATK_ACTION(m_element.get()), 0), String("press"));
+    const gchar* actionName = atk_action_get_name(ATK_ACTION(m_element.get()), 0);
+    return equalIgnoringCase(actionName, String("press")) || equalIgnoringCase(actionName, String("jump"));
 }
 
 bool AccessibilityUIElement::isIncrementActionSupported()