Fix a bug introduced in r230295 that A/B test result is not shown.
authordewei_zhu@apple.com <dewei_zhu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Apr 2018 03:18:07 +0000 (03:18 +0000)
committerdewei_zhu@apple.com <dewei_zhu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 6 Apr 2018 03:18:07 +0000 (03:18 +0000)
https://bugs.webkit.org/show_bug.cgi?id=184350

Reviewed by Ryosuke Niwa.

result.label should be assigned in `TestGroup._computeRequestedCommitSets`.

* public/v3/models/test-group.js:
(TestGroup.prototype._computeRequestedCommitSets):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/perf.webkit.org/ChangeLog
Websites/perf.webkit.org/public/v3/models/test-group.js

index e5929ba..40c0e7d 100644 (file)
@@ -1,3 +1,15 @@
+2018-04-05  Dewei Zhu  <dewei_zhu@apple.com>
+
+        Fix a bug introduced in r230295 that A/B test result is not shown.
+        https://bugs.webkit.org/show_bug.cgi?id=184350
+
+        Reviewed by Ryosuke Niwa.
+
+        result.label should be assigned in `TestGroup._computeRequestedCommitSets`.
+
+        * public/v3/models/test-group.js:
+        (TestGroup.prototype._computeRequestedCommitSets):
+
 2018-03-29  Dewei Zhu  <dewei_zhu@apple.com>
 
         Added UI to show potential regressions in chart with t-testing against segmentations.
index cf8f296..2da6220 100644 (file)
@@ -146,7 +146,7 @@ class TestGroup extends LabeledObject {
         if (beforeValues.length && afterValues.length) {
             const summary = metric.labelForDifference(beforeMean, afterMean, 'better', 'worse');
             result.changeType = summary.changeType;
-            result.changeLabel = summary.changeLabel;
+            result.label = summary.changeLabel;
             var isSignificant = Statistics.testWelchsT(beforeValues, afterValues);
             var significanceLabel = isSignificant ? 'significant' : 'insignificant';