Unreviewed. Rollout r240223. It regressed JetStream2 by 1%.
authorsbarati@apple.com <sbarati@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Jan 2019 19:41:10 +0000 (19:41 +0000)
committersbarati@apple.com <sbarati@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Jan 2019 19:41:10 +0000 (19:41 +0000)
JSTests:

* stress/arith-abs-to-arith-negate-range-optimizaton.js:
(testUncheckedBetweenIntMinInclusiveAndZeroExclusive):
(testUncheckedLessThanZero):
(testUncheckedLessThanOrEqualZero):
* stress/movhint-backwards-propagation-must-merge-use-as-value-add.js: Removed.
* stress/movhint-backwards-propagation-must-merge-use-as-value.js: Removed.

Source/JavaScriptCore:

* dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JSTests/ChangeLog
JSTests/stress/arith-abs-to-arith-negate-range-optimizaton.js
JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value-add.js [deleted file]
JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value.js [deleted file]
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.cpp

index 1c124da..d855bd4 100644 (file)
@@ -1,3 +1,14 @@
+2019-01-22  Saam Barati  <sbarati@apple.com>
+
+        Unreviewed. Rollout r240223. It regressed JetStream2 by 1%.
+
+        * stress/arith-abs-to-arith-negate-range-optimizaton.js:
+        (testUncheckedBetweenIntMinInclusiveAndZeroExclusive):
+        (testUncheckedLessThanZero):
+        (testUncheckedLessThanOrEqualZero):
+        * stress/movhint-backwards-propagation-must-merge-use-as-value-add.js: Removed.
+        * stress/movhint-backwards-propagation-must-merge-use-as-value.js: Removed.
+
 2019-01-22  Yusuke Suzuki  <ysuzuki@apple.com>
 
         [JSC] Invalidate old scope operations using global lexical binding epoch
index faeeae6..be22972 100644 (file)
@@ -233,7 +233,7 @@ function testUncheckedBetweenIntMinInclusiveAndZeroExclusive()
             throw "Failed testUncheckedBetweenIntMinInclusiveAndZeroExclusive() on -2147483648";
         }
     }
-    if (numberOfDFGCompiles(opaqueUncheckedBetweenIntMinInclusiveAndZeroExclusive) > 2) {
+    if (numberOfDFGCompiles(opaqueUncheckedBetweenIntMinInclusiveAndZeroExclusive) > 1) {
         throw "Failed optimizing testUncheckedBetweenIntMinInclusiveAndZeroExclusive(). None of the tested case need to OSR Exit.";
     }
 }
@@ -376,7 +376,7 @@ function testUncheckedLessThanZero()
             throw "Failed testUncheckedLessThanOrEqualZero() on -2147483648";
         }
     }
-    if (numberOfDFGCompiles(opaqueUncheckedLessThanZero) > 2) {
+    if (numberOfDFGCompiles(opaqueUncheckedLessThanZero) > 1) {
         throw "Failed optimizing testUncheckedLessThanZero(). None of the tested case need to OSR Exit.";
     }
 
@@ -420,7 +420,7 @@ function testUncheckedLessThanOrEqualZero()
             throw "Failed testUncheckedLessThanOrEqualZero() on -2147483648";
         }
     }
-    if (numberOfDFGCompiles(opaqueUncheckedLessThanOrEqualZero) > 2) {
+    if (numberOfDFGCompiles(opaqueUncheckedLessThanOrEqualZero) > 1) {
         throw "Failed optimizing testUncheckedLessThanOrEqualZero(). None of the tested case need to OSR Exit.";
     }
 }
diff --git a/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value-add.js b/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value-add.js
deleted file mode 100644 (file)
index 2330488..0000000
+++ /dev/null
@@ -1,16 +0,0 @@
-function foo(v, a, b) {
-    if (v) {
-        let r = a + b;
-        OSRExit();
-        return r;
-    }
-}
-noInline(foo);
-
-for (let i = 0; i < 10000; ++i) {
-    let r = foo(true, 4, 4);
-    if (r !== 8)
-        throw new Error("Bad!");
-}
-if (foo(true, 2**31 - 1, 1) !== 2**31)
-    throw new Error("Bad!");
diff --git a/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value.js b/JSTests/stress/movhint-backwards-propagation-must-merge-use-as-value.js
deleted file mode 100644 (file)
index 09772de..0000000
+++ /dev/null
@@ -1,16 +0,0 @@
-function foo(v, a, b) {
-    if (v) {
-        let r = a / b;
-        OSRExit();
-        return r;
-    }
-}
-noInline(foo);
-
-for (let i = 0; i < 10000; ++i) {
-    let r = foo(true, 4, 4);
-    if (r !== 1)
-        throw new Error("Bad!");
-}
-if (foo(true, 1, 4) !== 0.25)
-    throw new Error("Bad!");
index c5655c2..63b25d4 100644 (file)
@@ -1,3 +1,10 @@
+2019-01-22  Saam Barati  <sbarati@apple.com>
+
+        Unreviewed. Rollout r240223. It regressed JetStream2 by 1%.
+
+        * dfg/DFGBackwardsPropagationPhase.cpp:
+        (JSC::DFG::BackwardsPropagationPhase::propagate):
+
 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
 
         Unreviewed, restore bytecode cache-related JSC options deleted in r240254
index e98296f..f4ce71e 100644 (file)
@@ -205,6 +205,7 @@ private:
             break;
         }
             
+        case MovHint:
         case Check:
         case CheckVarargs:
             break;