Unreviewed, rolling out r123625 and r123672.
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 25 Jul 2012 23:29:00 +0000 (23:29 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 25 Jul 2012 23:29:00 +0000 (23:29 +0000)
http://trac.webkit.org/changeset/123625
http://trac.webkit.org/changeset/123672
https://bugs.webkit.org/show_bug.cgi?id=92315

Broke Windows and gcc builds (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-25

* platform/AutodrainedPool.h:
(AutodrainedPool):
* platform/ContentType.h:
(ContentType):
* platform/ContextMenu.h:
(ContextMenu):
* platform/ContextMenuItem.h:
(ContextMenuItem):
* platform/Cursor.h:
(WebCore::SharedCursor::SharedCursor):
(Cursor):
* platform/KURL.h:
(WebCore::KURL::KURL):
(KURL):
* platform/KURLGooglePrivate.h:
(KURLGooglePrivate):
* platform/PODRedBlackTree.h:
(WebCore::PODRedBlackTree::PODRedBlackTree):
* platform/Pasteboard.h:
(Pasteboard):
* platform/PlatformEvent.h:
(WebCore::PlatformEvent::PlatformEvent):
* platform/PlatformKeyboardEvent.h:
(PlatformKeyboardEvent):
* platform/PlatformMouseEvent.h:
(PlatformMouseEvent):
* platform/PlatformPasteboard.h:
(PlatformPasteboard):
* platform/PlatformTouchEvent.h:
(PlatformTouchEvent):
* platform/PlatformWheelEvent.h:
(PlatformWheelEvent):
* platform/RunLoop.h:
(TimerBase):
* platform/ScrollAnimator.h:
(ScrollAnimator):
* platform/ScrollAnimatorNone.h:
(ScrollAnimatorNone):
* platform/SharedBuffer.h:
(SharedBuffer):
* platform/WheelFlingPlatformGestureCurve.h:
(WheelFlingPlatformGestureCurve):
* platform/Widget.h:
(Widget):
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdateResourceRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 files changed:
Source/WebCore/ChangeLog
Source/WebCore/platform/AutodrainedPool.h
Source/WebCore/platform/ContentType.h
Source/WebCore/platform/ContextMenu.h
Source/WebCore/platform/ContextMenuItem.h
Source/WebCore/platform/Cursor.h
Source/WebCore/platform/KURL.h
Source/WebCore/platform/KURLGooglePrivate.h
Source/WebCore/platform/PODRedBlackTree.h
Source/WebCore/platform/Pasteboard.h
Source/WebCore/platform/PlatformEvent.h
Source/WebCore/platform/PlatformKeyboardEvent.h
Source/WebCore/platform/PlatformMouseEvent.h
Source/WebCore/platform/PlatformPasteboard.h
Source/WebCore/platform/PlatformTouchEvent.h
Source/WebCore/platform/PlatformWheelEvent.h
Source/WebCore/platform/RunLoop.h
Source/WebCore/platform/ScrollAnimator.h
Source/WebCore/platform/ScrollAnimatorNone.h
Source/WebCore/platform/SharedBuffer.h
Source/WebCore/platform/WheelFlingPlatformGestureCurve.h
Source/WebCore/platform/Widget.h
Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp

index 05e2d95..41e7a6c 100644 (file)
@@ -1,3 +1,59 @@
+2012-07-25  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r123625 and r123672.
+        http://trac.webkit.org/changeset/123625
+        http://trac.webkit.org/changeset/123672
+        https://bugs.webkit.org/show_bug.cgi?id=92315
+
+        Broke Windows and gcc builds (Requested by rniwa on #webkit).
+
+        * platform/AutodrainedPool.h:
+        (AutodrainedPool):
+        * platform/ContentType.h:
+        (ContentType):
+        * platform/ContextMenu.h:
+        (ContextMenu):
+        * platform/ContextMenuItem.h:
+        (ContextMenuItem):
+        * platform/Cursor.h:
+        (WebCore::SharedCursor::SharedCursor):
+        (Cursor):
+        * platform/KURL.h:
+        (WebCore::KURL::KURL):
+        (KURL):
+        * platform/KURLGooglePrivate.h:
+        (KURLGooglePrivate):
+        * platform/PODRedBlackTree.h:
+        (WebCore::PODRedBlackTree::PODRedBlackTree):
+        * platform/Pasteboard.h:
+        (Pasteboard):
+        * platform/PlatformEvent.h:
+        (WebCore::PlatformEvent::PlatformEvent):
+        * platform/PlatformKeyboardEvent.h:
+        (PlatformKeyboardEvent):
+        * platform/PlatformMouseEvent.h:
+        (PlatformMouseEvent):
+        * platform/PlatformPasteboard.h:
+        (PlatformPasteboard):
+        * platform/PlatformTouchEvent.h:
+        (PlatformTouchEvent):
+        * platform/PlatformWheelEvent.h:
+        (PlatformWheelEvent):
+        * platform/RunLoop.h:
+        (TimerBase):
+        * platform/ScrollAnimator.h:
+        (ScrollAnimator):
+        * platform/ScrollAnimatorNone.h:
+        (ScrollAnimatorNone):
+        * platform/SharedBuffer.h:
+        (SharedBuffer):
+        * platform/WheelFlingPlatformGestureCurve.h:
+        (WheelFlingPlatformGestureCurve):
+        * platform/Widget.h:
+        (Widget):
+        * platform/network/cf/ResourceRequestCFNet.cpp:
+        (WebCore::ResourceRequest::doUpdateResourceRequest):
+
 2012-07-25  Ryosuke Niwa  <rniwa@webkit.org>
 
         Windows build fix attempt after r123625.
index 7070c5f..207aadc 100644 (file)
@@ -38,7 +38,7 @@ namespace WebCore {
 class AutodrainedPool {
     WTF_MAKE_NONCOPYABLE(AutodrainedPool);
 public:
-    explicit AutodrainedPool(int iterationLimit = 1);
+    AutodrainedPool(int iterationLimit = 1);
     ~AutodrainedPool();
     
     void cycle();
index b3857cf..4583232 100644 (file)
@@ -33,7 +33,7 @@ namespace WebCore {
 
     class ContentType {
     public:
-        explicit ContentType(const String& type);
+        ContentType(const String& type);
 
         String parameter (const String& parameterName) const;
         String type() const;
index 4700db4..6a43b49 100644 (file)
@@ -71,7 +71,7 @@ namespace WebCore {
 
         void appendItem(const ContextMenuItem& item) { m_items.append(item); } 
 #else
-        explicit ContextMenu(const PlatformMenuDescription);
+        ContextMenu(const PlatformMenuDescription);
         ~ContextMenu();
 
         void insertItem(unsigned position, ContextMenuItem&);
index c05519f..9d36744 100644 (file)
@@ -277,8 +277,8 @@ namespace WebCore {
         const Vector<ContextMenuItem>& subMenuItems() const { return m_subMenuItems; }
 #else
     public:
-        explicit ContextMenuItem(PlatformMenuItemDescription);
-        explicit ContextMenuItem(ContextMenu* subMenu = 0);
+        ContextMenuItem(PlatformMenuItemDescription);
+        ContextMenuItem(ContextMenu* subMenu = 0);
         ContextMenuItem(ContextMenuAction, const String&, bool enabled, bool checked, Vector<ContextMenuItem>& submenuItems);
 
         PlatformMenuItemDescription releasePlatformDescription();
index 95f856e..d52f67c 100644 (file)
@@ -75,7 +75,7 @@ namespace WebCore {
         ~SharedCursor();
         HCURSOR nativeCursor() const { return m_nativeCursor; }
     private:
-        explicit SharedCursor(HCURSOR nativeCursor) : m_nativeCursor(nativeCursor) { }
+        SharedCursor(HCURSOR nativeCursor) : m_nativeCursor(nativeCursor) { }
         HCURSOR m_nativeCursor;
     };
     typedef RefPtr<SharedCursor> PlatformCursor;
@@ -158,18 +158,18 @@ namespace WebCore {
 
 #if !PLATFORM(IOS)
         Cursor(Image*, const IntPoint& hotSpot);
-        explicit Cursor(const Cursor&);
+        Cursor(const Cursor&);
         ~Cursor();
         Cursor& operator=(const Cursor&);
 
 #if USE(LAZY_NATIVE_CURSOR)
-        explicit Cursor(Type);
+        Cursor(Type);
         Type type() const { return m_type; }
         Image* image() const { return m_image.get(); }
         const IntPoint& hotSpot() const { return m_hotSpot; }
         PlatformCursor platformCursor() const;
 #else
-        explicit Cursor(PlatformCursor);
+        Cursor(PlatformCursor);
         PlatformCursor impl() const { return m_platformCursor; }
 #endif
 
index 9b647c6..ee67e16 100644 (file)
@@ -69,11 +69,11 @@ public:
     // It is usually best to avoid repeatedly parsing a string, unless memory saving outweigh the possible slow-downs.
     KURL(ParsedURLStringTag, const String&);
 #if USE(GOOGLEURL)
-    explicit KURL(WTF::HashTableDeletedValueType) : m_url(WTF::HashTableDeletedValue) { }
+    KURL(WTF::HashTableDeletedValueType) : m_url(WTF::HashTableDeletedValue) { }
 #elif USE(WTFURL)
-    explicit KURL(WTF::HashTableDeletedValueType) : m_urlImpl(WTF::HashTableDeletedValue) { }
+    KURL(WTF::HashTableDeletedValueType) : m_urlImpl(WTF::HashTableDeletedValue) { }
 #else
-    explicit KURL(WTF::HashTableDeletedValueType) : m_string(WTF::HashTableDeletedValue) { }
+    KURL(WTF::HashTableDeletedValueType) : m_string(WTF::HashTableDeletedValue) { }
 #endif
 #if !USE(WTFURL)
     bool isHashTableDeletedValue() const { return string().isHashTableDeletedValue(); }
@@ -195,7 +195,7 @@ public:
     operator const String&() const { return string(); }
 
 #if USE(CF)
-    explicit KURL(CFURLRef);
+    KURL(CFURLRef);
     CFURLRef createCFURL() const;
 #endif
 
index 6953c6f..374d0d7 100644 (file)
@@ -49,8 +49,8 @@ namespace WebCore {
     public:
         KURLGooglePrivate();
         KURLGooglePrivate(const url_parse::Parsed&, bool isValid);
-        explicit KURLGooglePrivate(WTF::HashTableDeletedValueType);
-        explicit KURLGooglePrivate(const KURLGooglePrivate&);
+        KURLGooglePrivate(WTF::HashTableDeletedValueType);
+        KURLGooglePrivate(const KURLGooglePrivate&);
         KURLGooglePrivate& operator=(const KURLGooglePrivate&);
 
         // Initializes the object. This will call through the backend initializer
index 5b5d3e0..7383580 100644 (file)
@@ -111,7 +111,7 @@ public:
     // isInitialized will return false in this case. initIfNeeded can be used
     // to init the structure. This constructor is usefull for creating
     // lazy initialized tree.
-    explicit PODRedBlackTree(UninitializedTreeEnum)
+    PODRedBlackTree(UninitializedTreeEnum)
         : m_root(0)
         , m_needsFullOrderingComparisons(false)
 #ifndef NDEBUG
index cc0809c..1fb8482 100644 (file)
@@ -79,7 +79,7 @@ public:
 #if PLATFORM(MAC)
     // This is required to support OS X services.
     void writeSelectionForTypes(const Vector<String>& pasteboardTypes, bool canSmartCopyOrDelete, Frame*);
-    explicit Pasteboard(const String& pasteboardName);
+    Pasteboard(const String& pasteboardName);
     static String getStringSelection(Frame*);
     static PassRefPtr<SharedBuffer> getDataSelection(Frame*, const String& pasteboardType);
 #endif
index 52c6488..5b32f44 100644 (file)
@@ -96,7 +96,7 @@ protected:
     {
     }
 
-    explicit PlatformEvent(Type type)
+    PlatformEvent(Type type)
         : m_type(type)
         , m_modifiers(0)
         , m_timestamp(0)
index a940ea9..42577f9 100644 (file)
@@ -170,16 +170,16 @@ namespace WebCore {
 #endif
 
 #if PLATFORM(WX)
-        explicit PlatformKeyboardEvent(wxKeyEvent&);
+        PlatformKeyboardEvent(wxKeyEvent&);
 #endif
 
 #if PLATFORM(BLACKBERRY)
-        explicit PlatformKeyboardEvent(const BlackBerry::Platform::KeyboardEvent&);
+        PlatformKeyboardEvent(const BlackBerry::Platform::KeyboardEvent&);
 #endif
 
 #if PLATFORM(EFL)
-        explicit PlatformKeyboardEvent(const Evas_Event_Key_Down*);
-        explicit PlatformKeyboardEvent(const Evas_Event_Key_Up*);
+        PlatformKeyboardEvent(const Evas_Event_Key_Down*);
+        PlatformKeyboardEvent(const Evas_Event_Key_Up*);
 #endif
 
     protected:
index 12c4eb5..44c9f5d 100644 (file)
@@ -103,8 +103,8 @@ namespace WebCore {
         
 
 #if PLATFORM(GTK) 
-        explicit PlatformMouseEvent(GdkEventButton*);
-        explicit PlatformMouseEvent(GdkEventMotion*);
+        PlatformMouseEvent(GdkEventButton*);
+        PlatformMouseEvent(GdkEventMotion*);
         void setClickCount(int count) { m_clickCount = count; }
 #endif
 
index 2fdd77b..27ef391 100644 (file)
@@ -42,7 +42,7 @@ class KURL;
 
 class PlatformPasteboard {
 public:
-    explicit PlatformPasteboard(const String& pasteboardName);
+    PlatformPasteboard(const String& pasteboardName);
     static String uniqueName();
     
     void getTypes(Vector<String>& types);
index dbfec22..019bd2a 100644 (file)
@@ -63,7 +63,7 @@ public:
 #if PLATFORM(EFL)
     PlatformTouchEvent(const Eina_List*, const IntPoint, PlatformEvent::Type, PlatformEvent::Modifiers);
 #elif PLATFORM(BLACKBERRY)
-    explicit PlatformTouchEvent(BlackBerry::Platform::TouchEvent*);
+    PlatformTouchEvent(BlackBerry::Platform::TouchEvent*);
 #endif
 
     const Vector<PlatformTouchPoint>& touchPoints() const { return m_touchPoints; }
index 8e08884..3997255 100644 (file)
@@ -152,11 +152,11 @@ namespace WebCore {
         bool directionInvertedFromDevice() const { return m_directionInvertedFromDevice; }
 
 #if PLATFORM(GTK)
-        explicit PlatformWheelEvent(GdkEventScroll*);
+        PlatformWheelEvent(GdkEventScroll*);
 #endif
 
 #if PLATFORM(EFL)
-        explicit PlatformWheelEvent(const Evas_Event_Mouse_Wheel*);
+        PlatformWheelEvent(const Evas_Event_Mouse_Wheel*);
 #endif
 
 #if PLATFORM(MAC) || PLATFORM(CHROMIUM)
@@ -180,7 +180,7 @@ namespace WebCore {
 #endif
 
 #if PLATFORM(HAIKU)
-        explicit PlatformWheelEvent(BMessage*);
+        PlatformWheelEvent(BMessage*);
 #endif
 
     protected:
index ce9845e..35f33e9 100644 (file)
@@ -67,7 +67,7 @@ public:
     class TimerBase {
         friend class RunLoop;
     public:
-        explicit TimerBase(RunLoop*);
+        TimerBase(RunLoop*);
         virtual ~TimerBase();
 
         void startRepeating(double repeatInterval) { start(repeatInterval, true); }
index 0c5f32c..4e5c427 100644 (file)
@@ -95,7 +95,7 @@ public:
     virtual bool isRubberBandInProgress() const { return false; }
 
 protected:
-    explicit ScrollAnimator(ScrollableArea*);
+    ScrollAnimator(ScrollableArea*);
 
     virtual void notifyPositionChanged();
 
index ae18c02..3b683f1 100644 (file)
@@ -53,7 +53,7 @@ struct ScrollAnimatorParameters;
 
 class ScrollAnimatorNone : public ScrollAnimator, public PlatformGestureCurveTarget {
 public:
-    explicit ScrollAnimatorNone(ScrollableArea*);
+    ScrollAnimatorNone(ScrollableArea*);
     virtual ~ScrollAnimatorNone();
 
     virtual bool scroll(ScrollbarOrientation, ScrollGranularity, float step, float multiplier);
index 90a2a35..879e4b2 100644 (file)
@@ -119,7 +119,7 @@ public:
 
 private:
     SharedBuffer();
-    explicit SharedBuffer(size_t);
+    SharedBuffer(size_t);
     SharedBuffer(const char*, int);
     SharedBuffer(const unsigned char*, int);
     
@@ -144,7 +144,7 @@ private:
     unsigned copySomeDataFromDataArray(const char*& someData, unsigned position) const;
 #endif
 #if USE(CF)
-    explicit SharedBuffer(CFDataRef);
+    SharedBuffer(CFDataRef);
     RetainPtr<CFDataRef> m_cfData;
 #endif
 };
index 44d552a..a6eeca4 100644 (file)
@@ -47,7 +47,7 @@ public:
     virtual bool apply(double time, PlatformGestureCurveTarget*);
 
 private:
-    explicit WheelFlingPlatformGestureCurve(const FloatPoint& velocity);
+    WheelFlingPlatformGestureCurve(const FloatPoint& velocity);
 
     FloatPoint m_velocity;
     IntPoint m_cumulativeScroll;
index 65f04d9..345b321 100644 (file)
@@ -127,7 +127,7 @@ enum WidgetNotification { WillPaintFlattened, DidPaintFlattened };
 //
 class Widget : public RefCounted<Widget> {
 public:
-    explicit Widget(PlatformWidget = 0);
+    Widget(PlatformWidget = 0);
     virtual ~Widget();
 
     PlatformWidget platformWidget() const;
index caaed0d..520d685 100644 (file)
@@ -192,7 +192,7 @@ void ResourceRequest::doUpdateResourceRequest()
         return;
     }
 
-    m_url = KURL(CFURLRequestGetURL(m_cfRequest.get()));
+    m_url = CFURLRequestGetURL(m_cfRequest.get());
 
     m_cachePolicy = (ResourceRequestCachePolicy)CFURLRequestGetCachePolicy(m_cfRequest.get());
     m_timeoutInterval = CFURLRequestGetTimeoutInterval(m_cfRequest.get());