REGRESSION (r232520): Crash under IPC::ArgumentCoder<WebCore::Credential>::encodePlat...
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 7 Jun 2018 07:05:55 +0000 (07:05 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 7 Jun 2018 07:05:55 +0000 (07:05 +0000)
https://bugs.webkit.org/show_bug.cgi?id=186385
<rdar://problem/40853796>

Reviewed by Daniel Bates.

* Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<Credential>::encodePlatformData): Fixed an incorrect cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@232576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm

index 987c1ae..409d36a 100644 (file)
@@ -1,3 +1,14 @@
+2018-06-07  Dan Bernstein  <mitz@apple.com>
+
+        REGRESSION (r232520): Crash under IPC::ArgumentCoder<WebCore::Credential>::encodePlatformData
+        https://bugs.webkit.org/show_bug.cgi?id=186385
+        <rdar://problem/40853796>
+
+        Reviewed by Daniel Bates.
+
+        * Shared/mac/WebCoreArgumentCodersMac.mm:
+        (IPC::ArgumentCoder<Credential>::encodePlatformData): Fixed an incorrect cast.
+
 2018-06-06  Per Arne Vollan  <pvollan@apple.com>
 
         Crash in lambda function WTF::Function<void ()>::CallableWrapper<WebKit::DisplayLink::displayLinkCallback
index 3985cdc..c530bb5 100644 (file)
@@ -479,7 +479,7 @@ void ArgumentCoder<Credential>::encodePlatformData(Encoder& encoder, const Crede
 
     auto archiver = secureArchiver();
     [archiver encodeObject:nsCredential forKey:@"credential"];
-    IPC::encode(encoder, (__bridge CFArrayRef)archiver.get().encodedData);
+    IPC::encode(encoder, (__bridge CFDataRef)archiver.get().encodedData);
 }
 
 bool ArgumentCoder<Credential>::decodePlatformData(Decoder& decoder, Credential& credential)