LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Jul 2016 05:47:05 +0000 (05:47 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Jul 2016 05:47:05 +0000 (05:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=160262

Reviewed by Daniel Bates.

* LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
(-[LTRelayController installApp]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@203811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m

index ae3e552..10d7592 100644 (file)
@@ -1,3 +1,13 @@
+2016-07-27  Alexey Proskuryakov  <ap@apple.com>
+
+        LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
+        https://bugs.webkit.org/show_bug.cgi?id=160262
+
+        Reviewed by Daniel Bates.
+
+        * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
+        (-[LTRelayController installApp]):
+
 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
 
         Disable WebCoreNSURLSessionTest API tests on ios-simulator
 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
 
         Disable WebCoreNSURLSessionTest API tests on ios-simulator
index 942c7dc..76749ed 100644 (file)
 {
     NSDictionary *installOptions = @{
         (NSString *)kCFBundleIdentifierKey: self.appBundleIdentifier,
 {
     NSDictionary *installOptions = @{
         (NSString *)kCFBundleIdentifierKey: self.appBundleIdentifier,
+        @"LSBlockUntilComplete": @YES,
     };
 
     NSError *error = nil;
     };
 
     NSError *error = nil;
-    [self.device installApplication:[NSURL fileURLWithPath:self.appPath] withOptions:installOptions error:&error];
-    if (error) {
+    BOOL installed = [self.device installApplication:[NSURL fileURLWithPath:self.appPath] withOptions:installOptions error:&error];
+    if (!installed) {
         NSLog(@"Couldn't install %@: %@", self.appPath, error.description);
         exit(EXIT_FAILURE);
     }
         NSLog(@"Couldn't install %@: %@", self.appPath, error.description);
         exit(EXIT_FAILURE);
     }