Reviewed by Adam Roben.
authortimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Jan 2008 22:43:44 +0000 (22:43 +0000)
committertimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Jan 2008 22:43:44 +0000 (22:43 +0000)
        <rdar://problem/5671059> Always show the Timeline and Console buttons in the Inspector

        * page/inspector/inspector.css: Remove styles related to the toggle button
          and make the area always visible.
        * page/inspector/inspector.html: Remove the toggle button.
        * page/inspector/inspector.js: Remove code to toggle the status area.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/page/inspector/inspector.css
WebCore/page/inspector/inspector.html
WebCore/page/inspector/inspector.js

index f9e53e3..eacb84d 100644 (file)
@@ -1,3 +1,14 @@
+2008-01-04  Timothy Hatcher  <timothy@apple.com>
+
+        Reviewed by Adam Roben.
+
+        <rdar://problem/5671059> Always show the Timeline and Console buttons in the Inspector
+
+        * page/inspector/inspector.css: Remove styles related to the toggle button
+          and make the area always visible. 
+        * page/inspector/inspector.html: Remove the toggle button.
+        * page/inspector/inspector.js: Remove code to toggle the status area.
+
 2008-01-04  Alexey Proskuryakov  <ap@webkit.org>
 
         Reviewed by Adam Roben.
index c16424a..308551a 100644 (file)
@@ -351,22 +351,6 @@ body.inactive #sidebar {
     background-image: url(Images/sidebarActionWidgetPressed.png);
 }
 
-#statusbar #statusToggle {
-    background-image: url(Images/showStatusWidget.png);
-}
-
-#statusbar #statusToggle:active {
-    background-image: url(Images/showStatusWidgetPressed.png);
-}
-
-#statusbar #statusToggle.hide {
-    background-image: url(Images/hideStatusWidget.png);
-}
-
-#statusbar #statusToggle.hide:active {
-    background-image: url(Images/hideStatusWidgetPressed.png);
-}
-
 body.detached #attachToggle {
     background-image: url(Images/sidebarAttachWidget.png);
 }
@@ -386,7 +370,7 @@ body.attached #attachToggle:active {
 #status {
     overflow: hidden;
     position: absolute;
-    bottom: -57px;
+    bottom: 21px;
     left: 0;
     width: 100%;
     height: 78px;
@@ -399,10 +383,6 @@ body.attached #attachToggle:active {
     -webkit-transition: bottom 250ms ease-in-out;
 }
 
-#status.visible {
-    bottom: 21px;
-}
-
 #status li {
     position: relative;
     height: 37px;
@@ -472,7 +452,7 @@ body.attached #attachToggle:active {
     position: absolute;
     top: 0;
     left: 0;
-    bottom: 21px;
+    bottom: 99px;
     width: 100%;
     padding: 2px 0;
     margin: 0;
@@ -482,10 +462,6 @@ body.attached #attachToggle:active {
     -webkit-transition: bottom 250ms ease-in-out;
 }
 
-#list.status-visible {
-    bottom: 99px;
-}
-
 #list > li {
     height: 26px;
     color: rgb(96, 110, 128);
index 43a3de2..3ba0300 100644 (file)
@@ -61,7 +61,7 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
         <ol id="list"></ol>
         <ol id="status"></ol>
         <div id="statusbar">
-            <button id="statusToggle"></button><button id="attachToggle"></button>
+            <button id="attachToggle"></button>
             <span id="sidebarResizeWidget"></span>
         </div>
         <div id="sidebarResizer" class="sidebar-resizer-vertical sidebar-resizer-vertical-left"></div>
index dbd4c0b..380c038 100644 (file)
@@ -147,33 +147,6 @@ var WebInspector = {
         }
     },
 
-    get showingStatusArea()
-    {
-        return this._showingStatusArea;
-    },
-
-    set showingStatusArea(x)
-    {
-        if (this._showingStatusArea === x)
-            return;
-
-        this._showingStatusArea = x;
-
-        var list = document.getElementById("list");
-        var status = document.getElementById("status");
-        var statusButton = document.getElementById("statusToggle");
-
-        if (x) {
-            statusButton.addStyleClass("hide");
-            list.addStyleClass("status-visible");
-            status.addStyleClass("visible");
-        } else {
-            statusButton.removeStyleClass("hide");
-            list.removeStyleClass("status-visible");
-            status.removeStyleClass("visible");
-        }
-    },
-
     get showingSearchResults()
     {
         return this._showingSearchResults;
@@ -281,7 +254,6 @@ WebInspector.loaded = function()
     this.updateBackForwardButtons();
 
     document.getElementById("attachToggle").addEventListener("click", this.toggleAttach.bind(this), true);
-    document.getElementById("statusToggle").addEventListener("click", this.toggleStatusArea.bind(this), true);
 
     document.getElementById("sidebarResizeWidget").addEventListener("mousedown", this.sidebarResizerDragStart, true);
     document.getElementById("sidebarResizer").addEventListener("mousedown", this.sidebarResizerDragStart, true);
@@ -401,13 +373,13 @@ WebInspector.sidebarKeyDown = function(event)
     var nextSelectedElement;
 
     if (this.fileOutline.selectedTreeElement) {
-        if (!this.fileOutline.handleKeyEvent(event) && event.keyIdentifier === "Down" && !event.altKey && this.showingStatusArea) {
+        if (!this.fileOutline.handleKeyEvent(event) && event.keyIdentifier === "Down" && !event.altKey) {
             var nextSelectedElement = this.statusOutline.children[0];
             while (nextSelectedElement && !nextSelectedElement.selectable)
                 nextSelectedElement = nextSelectedElement.traverseNextTreeElement(false);
         }
     } else if (this.statusOutline.selectedTreeElement) {
-        if (!this.showingStatusArea || (!this.statusOutline.handleKeyEvent(event) && event.keyIdentifier === "Up" && !event.altKey)) {
+        if (!this.statusOutline.handleKeyEvent(event) && event.keyIdentifier === "Up" && !event.altKey) {
             var nextSelectedElement = this.fileOutline.children[0];
             var lastSelectable = null;
 
@@ -539,11 +511,6 @@ WebInspector.toggleAttach = function()
     this.attached = !this.attached;
 }
 
-WebInspector.toggleStatusArea = function()
-{
-    this.showingStatusArea = !this.showingStatusArea;
-}
-
 WebInspector.toolbarDragStart = function(event)
 {
     var toolbar = document.getElementById("toolbar");
@@ -697,13 +664,11 @@ WebInspector.updateBackForwardButtons = function()
 
 WebInspector.showConsole = function()
 {
-    this.showingStatusArea = true;
     this.navigateToPanel(WebInspector.consolePanel);
 }
 
 WebInspector.showTimeline = function()
 {
-    this.showingStatusArea = true;
     this.navigateToPanel(WebInspector.networkPanel);
 }
 
@@ -765,11 +730,9 @@ WebInspector.addMessageToConsole = function(msg)
     switch (msg.level) {
         case WebInspector.ConsoleMessage.MessageLevel.Warning:
             ++this.consoleListItem.warnings;
-            this.showingStatusArea = true;
             break;
         case WebInspector.ConsoleMessage.MessageLevel.Error:
             ++this.consoleListItem.errors;
-            this.showingStatusArea = true;
             break;
     }
 }