Remove compile time flag ENABLE_PASSWORD_ECHO
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 7 Oct 2011 20:05:34 +0000 (20:05 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 7 Oct 2011 20:05:34 +0000 (20:05 +0000)
https://bugs.webkit.org/show_bug.cgi?id=69647

Source/WebCore:

As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-07
Reviewed by Andreas Kling.

* config.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):

Source/WebKit/qt:

As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-07
Reviewed by Andreas Kling.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):

LayoutTests:

WK2 tests are passing after r96740 (bug 68924).

Patch by Chang Shu <cshu@webkit.org> on 2011-10-07
Reviewed by Andreas Kling.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/wk2/Skipped
Source/WebCore/ChangeLog
Source/WebCore/config.h
Source/WebCore/page/Settings.cpp
Source/WebKit/qt/Api/qwebsettings.cpp
Source/WebKit/qt/ChangeLog

index c026e95..fa9567a 100644 (file)
@@ -1,3 +1,14 @@
+2011-10-07  Chang Shu  <cshu@webkit.org>
+
+        Remove compile time flag ENABLE_PASSWORD_ECHO
+        https://bugs.webkit.org/show_bug.cgi?id=69647
+
+        WK2 tests are passing after r96740 (bug 68924).
+
+        Reviewed by Andreas Kling.
+
+        * platform/wk2/Skipped:
+
 2011-10-07  Chris Fleizach  <cfleizach@apple.com>
 
         Bug 69562 - AccessibilityImageMapLink holds onto it's parent even after it's been freed
index 443c9a0..3c3a326 100644 (file)
@@ -1102,13 +1102,6 @@ editing/spelling/spellcheck-input-search-crash.html
 # missing window.internals.createShadowContentElement
 fast/dom/shadow/create-content-element.html
 
-# WebKitTestRunner needs layoutTestController.setPasswordEchoEnabled
-# WebKitTestRunner needs layoutTestController.setPasswordEchoDuration
-editing/input/password-echo-passnode.html
-editing/input/password-echo-passnode2.html
-editing/input/password-echo-passnode3.html
-editing/input/password-echo-textnode.html
-
 # WTR needs an implementation for eventSender.continuousMouseScrollBy
 # https://bugs.webkit.org/show_bug.cgi?id=69417
 fast/events/wheelevent-direction-inverted-from-device.html
index 36cb422..7465e0f 100644 (file)
@@ -1,3 +1,16 @@
+2011-10-07  Chang Shu  <cshu@webkit.org>
+
+        Remove compile time flag ENABLE_PASSWORD_ECHO
+        https://bugs.webkit.org/show_bug.cgi?id=69647
+
+        As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.
+
+        Reviewed by Andreas Kling.
+
+        * config.h:
+        * page/Settings.cpp:
+        (WebCore::Settings::Settings):
+
 2011-10-07  Chris Fleizach  <cfleizach@apple.com>
 
         Bug 69562 - AccessibilityImageMapLink holds onto it's parent even after it's been freed
index 8ca7c78..0cd7f36 100644 (file)
 
 #if OS(SYMBIAN)
 #define USE_SYSTEM_MALLOC 1
-#define ENABLE_PASSWORD_ECHO 1
 #endif
 
 #if OS(UNIX) || OS(WINDOWS)
index 6caf6e2..68b3142 100644 (file)
@@ -215,7 +215,11 @@ Settings::Settings(Page* page)
 #endif
     , m_mediaPlaybackRequiresUserGesture(false)
     , m_mediaPlaybackAllowsInline(true)
+#if OS(SYMBIAN)
+    , m_passwordEchoEnabled(true)
+#else
     , m_passwordEchoEnabled(false)
+#endif
     , m_suppressIncrementalRendering(false)
     , m_loadsImagesAutomaticallyTimer(this, &Settings::loadsImagesAutomaticallyTimerFired)
     , m_zoomAnimatorScale(1)
index 4d5c612..7842144 100644 (file)
@@ -284,11 +284,6 @@ void QWebSettingsPrivate::apply()
         settings->setNeedsSiteSpecificQuirks(value);
 
         settings->setUsesPageCache(WebCore::pageCache()->capacity());
-
-#if ENABLE(PASSWORD_ECHO)
-        settings->setPasswordEchoEnabled(true);
-        settings->setPasswordEchoDurationInSeconds(1);
-#endif
     } else {
         QList<QWebSettingsPrivate*> settings = *::allSettings();
         for (int i = 0; i < settings.count(); ++i)
index 8a8f9b2..9d9f941 100644 (file)
@@ -1,3 +1,15 @@
+2011-10-07  Chang Shu  <cshu@webkit.org>
+
+        Remove compile time flag ENABLE_PASSWORD_ECHO
+        https://bugs.webkit.org/show_bug.cgi?id=69647
+
+        As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.
+
+        Reviewed by Andreas Kling.
+
+        * Api/qwebsettings.cpp:
+        (QWebSettingsPrivate::apply):
+
 2011-10-06  Fady Samuel  <fsamuel@chromium.org>
 
         Code clean-up: Make RenderObject::absoluteBoundingBoxRect and associated methods const and make its parameter useTransforms no longer default to false