Media controls draw behind captions
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 17 Jul 2017 12:55:29 +0000 (12:55 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 17 Jul 2017 12:55:29 +0000 (12:55 +0000)
commitffb61792cc125b280f086fb139689cd725a0f3e6
tree3c3c69f26fad462a18ece9222d5ed49779709c9d
parenta991b78541b950f7a67fb6e88d894df4e673f6de
Media controls draw behind captions
https://bugs.webkit.org/show_bug.cgi?id=174579
<rdar://problem/33295427>

Reviewed by Dean Jackson.

Source/WebCore:

Ensure the captions container is added as a previous sibling to the controls container.

Test: media/modern-media-controls/media-controls/media-controls-display-above-captions.html

* Modules/modern-media-controls/media/media-controller.js:
(MediaController):

LayoutTests:

Add a new test that checks the order in which order the captions and controls containers appear
under the media shadow root.

* media/modern-media-controls/media-controls/media-controls-display-above-captions-expected.txt: Added.
* media/modern-media-controls/media-controls/media-controls-display-above-captions.html: Added.
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@219558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/media/modern-media-controls/media-controls/media-controls-display-above-captions-expected.txt [new file with mode: 0644]
LayoutTests/media/modern-media-controls/media-controls/media-controls-display-above-captions.html [new file with mode: 0644]
LayoutTests/platform/ios-simulator/TestExpectations
LayoutTests/platform/mac/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/Modules/modern-media-controls/media/media-controller.js