F4 key should open the picker popup on Windows and Linux
authorkeishi@webkit.org <keishi@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 Oct 2012 14:04:09 +0000 (14:04 +0000)
committerkeishi@webkit.org <keishi@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 Oct 2012 14:04:09 +0000 (14:04 +0000)
commitfee3e03f78496c11ad0d7f075585bad0ec950df9
tree73b42a105b0534ccb9a33a9cb3d565da02edfbac
parentb0a2f2dff072e4da5dcfcf63464e01cb7cdd0eac
F4 key should open the picker popup on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=98754

Reviewed by Kent Tamura.

Source/WebCore:

On Windows, F4 key is used to open the combo box popup. We will introduce the same keybinding for picker popups.

Added test to calendar-picker-key-operations.html, date-suggestion-picker-key-operations.html, time-suggestion-picker-key-operations.html.

* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleKeydownEvent): Open picker on F4 key if it is enabled.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::shouldOpenPickerWithF4Key): Returns true if we want to enable the F4 key binding on this platform. Return false for default.
(WebCore):
* rendering/RenderTheme.h:
(RenderTheme):
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderThemeChromiumLinux::shouldOpenPickerWithF4Key): Returns true.
(WebCore):
* rendering/RenderThemeChromiumLinux.h:
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::shouldOpenPickerWithF4Key): Returns true.
* rendering/RenderThemeChromiumWin.h:
(RenderThemeChromiumWin):

LayoutTests:

* fast/forms/date/calendar-picker-key-operations.html:
* platform/chromium-win/fast/forms/date/calendar-picker-key-operations-expected.txt: Added.
* platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt:
* platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/date/date-suggestion-picker-key-operations.html:
* platform/chromium/fast/forms/time/time-suggestion-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/time/time-suggestion-picker-key-operations.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
17 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/forms/date/calendar-picker-key-operations.html
LayoutTests/platform/chromium-win/fast/forms/date/calendar-picker-key-operations-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-key-operations-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt
LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-key-operations.html
LayoutTests/platform/chromium/fast/forms/time/time-suggestion-picker-key-operations-expected.txt
LayoutTests/platform/chromium/fast/forms/time/time-suggestion-picker-key-operations.html
Source/WebCore/ChangeLog
Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp
Source/WebCore/rendering/RenderTheme.cpp
Source/WebCore/rendering/RenderTheme.h
Source/WebCore/rendering/RenderThemeChromiumLinux.cpp
Source/WebCore/rendering/RenderThemeChromiumLinux.h
Source/WebCore/rendering/RenderThemeChromiumWin.cpp
Source/WebCore/rendering/RenderThemeChromiumWin.h