Rename HTMLInputElement::isIndeterminate to Element::shouldAppearIndeterminate
authortkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Mar 2013 08:26:04 +0000 (08:26 +0000)
committertkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Mar 2013 08:26:04 +0000 (08:26 +0000)
commitfe1f0e6f91c81593ffb817533abf30a5c2005015
treee1d32069829bcef540ed8afd0b1fe3f6b4a5ada6
parent75bc65579b2715ad0217cc1f64a318ba9ca3b9c9
Rename HTMLInputElement::isIndeterminate to Element::shouldAppearIndeterminate
https://bugs.webkit.org/show_bug.cgi?id=113264

Reviewed by Kentaro Hara.

HTMLInputElement had indeterminate() and isIndeterminate(). It's very
confusing.

Because indeterminate is a public DOM function and isIndeterminate is
for CSS and rendering, we rename isIndetermiante to
shouldAppearIndeterminate. Also, HTMLProgressElement, which support
:indeterminate pseudo class, should follow it. We add
shouldAppearIndeterminate to Element.

No new tests. Just a refactoring.

* dom/Element.cpp:
(WebCore::Element::shouldAppearIndeterminate): Added. Returns false.
* dom/Element.h:
(Element): Declare shouldAppearIndeterminate.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::shouldAppearIndeterminate):
Renamed from isIndeterminate.
* html/HTMLInputElement.h:
(HTMLInputElement): Rename isIndeterminate to shouldAppearIndeterminate,
and overrides Element::shouldAppearIndeterminate.
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::shouldAppearIndeterminate): Added.
* html/HTMLProgressElement.h: Add shouldAppearIndeterminate.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isIndeterminate):
Use shouldAppearIndeterminate.
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne): Ditto.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithControl): Ditto.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isIndeterminate): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/accessibility/AccessibilityNodeObject.cpp
Source/WebCore/css/SelectorChecker.cpp
Source/WebCore/css/StyleResolver.cpp
Source/WebCore/dom/Element.cpp
Source/WebCore/dom/Element.h
Source/WebCore/html/HTMLInputElement.cpp
Source/WebCore/html/HTMLInputElement.h
Source/WebCore/html/HTMLProgressElement.cpp
Source/WebCore/html/HTMLProgressElement.h
Source/WebCore/rendering/RenderTheme.cpp