2011-01-17 John Knottenbelt <jknotten@chromium.org>
authorjknotten@chromium.org <jknotten@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 17 Jan 2011 12:21:55 +0000 (12:21 +0000)
committerjknotten@chromium.org <jknotten@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 17 Jan 2011 12:21:55 +0000 (12:21 +0000)
commitfc19c02573c2cd12a183af33396761ebfa7ccbc8
tree69f2208fad1f2692b8ee3c2e57dba93a9218a02b
parente94d2b923113e7e32485167d596c54da43430011
2011-01-17  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        GeolocationController should call stopUpdating on destruction
        https://bugs.webkit.org/show_bug.cgi?id=52216

        fast/dom/window-close-crash.html tests that we do not fail the
        assertion in the mock GeolocationClient that the GeolocationClient
        is not updating when the GeolocationController is destroyed.

        * fast/dom/Geolocation/resources/window-close-popup.html: Added.
        * fast/dom/Geolocation/script-tests/window-close-crash.js: Added.
        (gotPosition):
        (waitForWindowToClose):
        (failedToCreateWatch):
        * fast/dom/Geolocation/window-close-crash-expected.txt: Added.
        * fast/dom/Geolocation/window-close-crash.html: Added.
        * platform/gtk/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
2011-01-17  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        GeolocationController should call stopUpdating on destruction
        https://bugs.webkit.org/show_bug.cgi?id=52216

        Test: fast/dom/Geolocation/window-close-crash.html

        * page/GeolocationController.cpp:
        (WebCore::GeolocationController::~GeolocationController):
2011-01-17  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        GeolocationController should call stopUpdating on destruction
        https://bugs.webkit.org/show_bug.cgi?id=52216

        fast/dom/Geolocation/window-close-crash.html requires that a
        Geolocation watch be started in a secondary window. Consequently,
        we need to allow geolocation permission and provide a mock
        geolocation position for the secondary window's
        GeolocationClientMock.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setGeolocationPermission):
        (LayoutTestController::setMockGeolocationPosition):
        (LayoutTestController::setMockGeolocationError):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::windowList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
13 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/dom/Geolocation/resources/window-close-popup.html [new file with mode: 0644]
LayoutTests/fast/dom/Geolocation/script-tests/window-close-crash.js [new file with mode: 0644]
LayoutTests/fast/dom/Geolocation/window-close-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/dom/Geolocation/window-close-crash.html [new file with mode: 0644]
LayoutTests/platform/gtk/Skipped
LayoutTests/platform/mac-wk2/Skipped
LayoutTests/platform/qt-wk2/Skipped
Source/WebCore/ChangeLog
Source/WebCore/page/GeolocationController.cpp
Tools/ChangeLog
Tools/DumpRenderTree/chromium/LayoutTestController.cpp
Tools/DumpRenderTree/chromium/TestShell.h