Crash in WebCore::RenderBlock::willBeDestroyed
authorinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Jan 2013 21:37:46 +0000 (21:37 +0000)
committerinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Jan 2013 21:37:46 +0000 (21:37 +0000)
commitfbec385259b426b0498ff92947d18718633c9503
tree5dcf4fd41ef8a5643c5af2c1d604e480c916a288
parent5f2e2a4d5e57786953e9b99d2436d8e0cb227ad6
Crash in WebCore::RenderBlock::willBeDestroyed
https://bugs.webkit.org/show_bug.cgi?id=103455

Reviewed by Eric Seidel.

Source/WebCore:

It is not required to set beforeChild to :after child since DOM is
now pseudo element aware. See trac.webkit.org/changeset/137336. We
were incorrectly placing the inline continuation before the :after
content.

Test: fast/multicol/continuation-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): remove beforeChild
setting to afterPseudoElementRenderer.
* rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::addChild): add missing beforeChild argument.
setting to afterPseudoElementRenderer.
(WebCore::RenderRubyAsBlock::addChild): add missing beforeChild argument.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild): remove beforeChild
setting to afterPseudoElementRenderer.
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild): remove beforeChild
setting to afterPseudoElementRenderer.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild): remove beforeChild
setting to afterPseudoElementRenderer.

LayoutTests:

* fast/multicol/continuation-crash-expected.txt: Added.
* fast/multicol/continuation-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/multicol/continuation-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/multicol/continuation-crash.html [new file with mode: 0755]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBlock.cpp
Source/WebCore/rendering/RenderRuby.cpp
Source/WebCore/rendering/RenderTable.cpp
Source/WebCore/rendering/RenderTableRow.cpp
Source/WebCore/rendering/RenderTableSection.cpp