[GTK] [Stable] Infinite recursion in WebCore::AXObjectCache::getOrCreate
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 21 Sep 2012 19:40:19 +0000 (19:40 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 21 Sep 2012 19:40:19 +0000 (19:40 +0000)
commitfb9de4d2c2970d17e5555287307d9e339e4baac0
treeac8f60ea49c926951bf5bc08ef0cdb6d67c12e44
parent09741364d947cd20368301ceaed8af16d5a81982
[GTK] [Stable] Infinite recursion in WebCore::AXObjectCache::getOrCreate
https://bugs.webkit.org/show_bug.cgi?id=96932

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-21
Reviewed by Martin Robinson.

Source/WebCore:

Make the decision based on RenderObjects rather than AccessibilityObjects
to avoid the infinite recursion which occurs when remapAriaRoleDueToParent
gets called.

Test: platform/gtk/accessibility/remapped-aria-crash.html

* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

LayoutTests:

Added a new test which replicates the recursion and crash.

* platform/gtk/accessibility/remapped-aria-crash-expected.txt: Added.
* platform/gtk/accessibility/remapped-aria-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/platform/gtk/accessibility/remapped-aria-crash-expected.txt [new file with mode: 0644]
LayoutTests/platform/gtk/accessibility/remapped-aria-crash.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp