Get rid of Retry status in webkit-queues
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Sep 2014 16:58:41 +0000 (16:58 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Sep 2014 16:58:41 +0000 (16:58 +0000)
commitf8baa5d6e716651e24a63e35ed5633c74eca41d1
tree83bbe3ffcf3ec35ddde0e53b760236364c53b5b6
parent7b170774edb3507d9874a7fd7297719f4d42577f
Get rid of Retry status in webkit-queues
https://bugs.webkit.org/show_bug.cgi?id=137135

Reviewed by Ryosuke Niwa.

* QueueStatusServer/config/messages.py: Removed Retry.

* QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
no longer needs to check the latest status. It just always both unlocks the patch
and removes it from WorkItems.

* QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
I don't understand why we even needed to check for retries here, but now that there
are no retries, that code can go to /dev/null.

* QueueStatusServer/loggers/recordpatchevent.py:
(RecordPatchEvent.started):
(RecordPatchEvent.retrying): Deleted.
Fixed retry counting, it should work for all queues now.

* QueueStatusServer/model/queuestatus.py:
(QueueStatus.is_retry_request): Deleted. These are no more.

* Scripts/webkitpy/common/net/statusserver_mock.py:
(MockStatusServer.release_lock):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
Did whatever it took to keep passing the tests. The particular test doesn't seem
quite right, but whatever.

* Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue.process_work_item): Instead of posting a retry status, just unlock
and let others pick up. Also, added explicit returns for clarity.
(AbstractPatchQueue._did_retry): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@174009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Tools/ChangeLog
Tools/QueueStatusServer/app.yaml
Tools/QueueStatusServer/config/messages.py
Tools/QueueStatusServer/handlers/releasepatch.py
Tools/QueueStatusServer/handlers/submittoews.py
Tools/QueueStatusServer/loggers/recordpatchevent.py
Tools/QueueStatusServer/model/queuestatus.py
Tools/Scripts/webkitpy/common/net/statusserver_mock.py
Tools/Scripts/webkitpy/tool/commands/queues.py
Tools/Scripts/webkitpy/tool/commands/queues_unittest.py