flex-item-align: stretch should only grow, never shrink
authortony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 19 Mar 2012 19:11:14 +0000 (19:11 +0000)
committertony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 19 Mar 2012 19:11:14 +0000 (19:11 +0000)
commitf85af2890f461aaad9129af8253c07f48e3545df
treeb7993c208002ff0eb1394028087a289c3518e1de
parenta48733b188f373027c0d0a3bc3e7632f1bba6c64
flex-item-align: stretch should only grow, never shrink
https://bugs.webkit.org/show_bug.cgi?id=80882

Reviewed by Ojan Vafai.

Source/WebCore:

New test cases in css3/flexbox/flex-align-stretch.html.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::alignChildren): Move stretch code into a separate function.
(WebCore::RenderFlexibleBox::alignChildStretch): Add an early return if our height is shrinking.
(WebCore):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/child-overflow-expected.html:
* css3/flexbox/child-overflow.html: For cases that overflow the height, we now just overflow rather than reducing the height.
* css3/flexbox/flex-align-stretch-expected.txt:
* css3/flexbox/flex-align-stretch.html: New test cases.
* platform/chromium/test_expectations.txt: Mark as failing on Windows
because of mock scrollbar rendering bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/css3/flexbox/child-overflow-expected.html
LayoutTests/css3/flexbox/child-overflow.html
LayoutTests/css3/flexbox/flex-align-stretch-expected.txt
LayoutTests/css3/flexbox/flex-align-stretch.html
LayoutTests/platform/chromium/test_expectations.txt
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderFlexibleBox.cpp
Source/WebCore/rendering/RenderFlexibleBox.h