2009-06-28 John Abd-El-Malek <jam@chromium.org>
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 28 Jun 2009 10:31:58 +0000 (10:31 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 28 Jun 2009 10:31:58 +0000 (10:31 +0000)
commitf6d49344b2ac6d6deeebbd9414bd43dde9c7ab8a
tree6e3a6aed90f9c611300519673f36ff668f05bac7
parentf5dfb7e12e6ad052b88d26c4fc312976c4294b01
2009-06-28  John Abd-El-Malek  <jam@chromium.org>

        https://bugs.webkit.org/show_bug.cgi?id=15457

        Layout tests to ensure that "src" paramater is added when it's missing
        but "data" is present.

        * plugins/netscape-plugin-map-data-to-src-expected.txt: Added.
        * plugins/netscape-plugin-map-data-to-src.html: Added.

2009-06-28  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=15457

        Test: plugins/netscape-plugin-map-data-to-src.html

        Fix problems with Real or WMP plugins not displaying because "data" was set
        on the OBJECT tag instead of "src".  This is based on what Firefox does, see
        http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp#3045

        * rendering/RenderPartObject.cpp:
        (WebCore::mapDataParamToSrc):
        (WebCore::RenderPartObject::updateWidget):

2009-06-28  John Abd-El-Malek  <jam@chromium.org>

        https://bugs.webkit.org/show_bug.cgi?id=15457

        Modify NPAPI test plugin to verify that "src" paramater is added when
        it's missing but "data" is present.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (pluginLog):
        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (NPP_New):
        (NPP_Destroy):
        (NPP_SetWindow):
        (handleEventCarbon):
        (handleEventCocoa):
        * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
        (NPP_New):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/plugins/netscape-plugin-map-data-to-src-expected.txt [new file with mode: 0644]
LayoutTests/plugins/netscape-plugin-map-data-to-src.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/rendering/RenderPartObject.cpp
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp
WebKitTools/DumpRenderTree/win/TestNetscapePlugin/main.cpp