WebCore:
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 23 Aug 2008 07:16:41 +0000 (07:16 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 23 Aug 2008 07:16:41 +0000 (07:16 +0000)
commitf461d2106f7a03677e9a5ae2e6e2c8fae6c75144
tree6aae2a41053bf9057096ac200205cc8866077054
parentdaa9a6255997ef4f47a81582ad2cfd63bbfa81e9
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline

        Test: fast/table/vertical-align-baseline.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
        baseline of the first table row, if there is one, -1 otherwise.
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::baselinePosition): Changed to follow the
        CSS2.1 definition of the baseline of a table cell.
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
        the baseline of the first row in the section.
        * rendering/RenderTableSection.h:

LayoutTests:

        Reviewed by Dave Hyatt.

        - test and updated results for <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline

        * fast/table/vertical-align-baseline.html: Added.
        * platform/mac/fast/table/form-with-table-style-expected.checksum:
        * platform/mac/fast/table/form-with-table-style-expected.png:
        * platform/mac/fast/table/form-with-table-style-expected.txt:
        * platform/mac/fast/table/vertical-align-baseline-expected.checksum: Added.
        * platform/mac/fast/table/vertical-align-baseline-expected.png: Added.
        * platform/mac/fast/table/vertical-align-baseline-expected.txt: Added.
        * platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
18 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/table/vertical-align-baseline.html [new file with mode: 0644]
LayoutTests/platform/mac/fast/table/form-with-table-style-expected.checksum
LayoutTests/platform/mac/fast/table/form-with-table-style-expected.png
LayoutTests/platform/mac/fast/table/form-with-table-style-expected.txt
LayoutTests/platform/mac/fast/table/vertical-align-baseline-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/table/vertical-align-baseline-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/table/vertical-align-baseline-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt
WebCore/ChangeLog
WebCore/rendering/RenderTable.cpp
WebCore/rendering/RenderTable.h
WebCore/rendering/RenderTableCell.cpp
WebCore/rendering/RenderTableSection.cpp
WebCore/rendering/RenderTableSection.h