Move platformName property from testRunner to accessibilityController
authormario.prada@samsung.com <mario.prada@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Jan 2014 21:10:57 +0000 (21:10 +0000)
committermario.prada@samsung.com <mario.prada@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Jan 2014 21:10:57 +0000 (21:10 +0000)
commitf2fe74e289e8f0a152affa4f0de4e482e5883f55
tree720bcee7945c60c669fd4a3e9ae2d13952910c24
parentc75832d5d26af220c9c79f7343908bd819c1c8ad
Move platformName property from testRunner to accessibilityController
https://bugs.webkit.org/show_bug.cgi?id=126689

Reviewed by Chris Fleizach.

Tools:

Move the platformName property from the testRunner into
accessibilityController, since this is a concept that has only be
used by accessibility tests since it got added, and also because
the real intention was not to distinguish among "ports" (mac, win,
gtk, efl) but between platforms (atk, mac, win).

This change will be very useful to merge GTK's roles-exposed.html
and Mac's role-subrole-roledescription.html into one single test,
since we will be specifying in the test itself which elements are
supported in which accessibility "platform". In this context,
being able to check accessibilityController.platformName directly
against a list of supported accessibility platforms (e.g. "atk,mac")
will certainly maintain the code cleaner and simpler.

* DumpRenderTree/TestRunner.h:
(TestRunner::platformName): Removed.
* DumpRenderTree/TestRunner.cpp:
(getPlatformNameCallback): Removed.
(TestRunner::staticValues): Removed platformName
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::platformName): Removed.
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::platformName): Removed.
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::platformName): Removed.
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::platformName): Removed.

* DumpRenderTree/AccessibilityController.h:
(AccessibilityController::platformName): Added.
* DumpRenderTree/AccessibilityController.cpp:
(getPlatformNameCallback): Added.
(AccessibilityController::getJSClass): Added platformName.
* DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
(AccessibilityController::platformName): Added, returning "atk".
* DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::platformName): Ditto, returning "mac".
* DumpRenderTree/ios/AccessibilityControllerIOS.mm:
(AccessibilityController::platformName): Ditto, returning "ios".
* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::platformName): Ditto, returning "win".

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
(platformName): Removed.
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner::platformName): Removed.
* WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
(TestRunner::platformName): Removed.
* WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(TestRunner::platformName): Removed.
* WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
(TestRunner::platformName): Removed.
* WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
(TestRunner::platformName): Removed.

* WebKitTestRunner/InjectedBundle/AccessibilityController.h:
(WTR:AccessibilityController::platformName): Added.
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
(platformName): Added.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::platformName): Added, returning "atk".
* WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::AccessibilityController::platformName): Added, returning "mac".

LayoutTests:

Updated tests and expectations affected by the move of
platformName from TestRunner to AccessibilityController.

* accessibility/canvas-fallback-content.html:
* accessibility/ignore-spacer-elements.html:
* accessibility/platform-name.html:
* platform/efl/accessibility/platform-name-expected.txt:
* platform/gtk/accessibility/platform-name-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
29 files changed:
LayoutTests/ChangeLog
LayoutTests/accessibility/canvas-fallback-content.html
LayoutTests/accessibility/ignore-spacer-elements.html
LayoutTests/accessibility/platform-name.html
LayoutTests/platform/efl/accessibility/platform-name-expected.txt
LayoutTests/platform/gtk/accessibility/platform-name-expected.txt
Tools/ChangeLog
Tools/DumpRenderTree/AccessibilityController.cpp
Tools/DumpRenderTree/AccessibilityController.h
Tools/DumpRenderTree/TestRunner.cpp
Tools/DumpRenderTree/TestRunner.h
Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp
Tools/DumpRenderTree/efl/TestRunnerEfl.cpp
Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp
Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm
Tools/DumpRenderTree/mac/AccessibilityControllerMac.mm
Tools/DumpRenderTree/mac/TestRunnerMac.mm
Tools/DumpRenderTree/win/AccessibilityControllerWin.cpp
Tools/DumpRenderTree/win/TestRunnerWin.cpp
Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.h
Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl
Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp
Tools/WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp
Tools/WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp
Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm
Tools/WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm
Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp